This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Prevent proxies from sending toJSON calls via IPC#689
Merged
d-gubert merged 2 commits intofeat/deno-runtimefrom Dec 22, 2023
Merged
Prevent proxies from sending toJSON calls via IPC#689d-gubert merged 2 commits intofeat/deno-runtimefrom
d-gubert merged 2 commits intofeat/deno-runtimefrom
Conversation
d-gubert
commented
Dec 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
The proxies used to send method calls as request over IPC ended up also sending calls to the
toJSONmethod as a request. This, of course, makes no sense and only causes problems.This PR also adds a
toJSONimplementation to theAppabstract class, as the app instance can be sent over for configuration methods if the object sent has a reference to the App instance. E.g. instantiating a slashcommand class that takes the instace of the App as parameter via constructor.Why? 🤔
Links 🌎
PS 👀