This repository was archived by the owner on Nov 5, 2025. It is now read-only.
Merged
Conversation
d-gubert
approved these changes
Jul 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? ⛵
Allow video conf provider apps to list themselves as compatible with the new Rocket.Chat Persistent Chat feature.
When an app is flagged as compatible with this new feature, Rocket.Chat will let the app assign a discussion id to the conference on the
onNewVideoConferenceEvent. If no discussion is specified by the app in this event, Rocket.Chat will create one automatically. The app can then use the id of this dicussion on any other event as necessary.In this first implementation there's no way for apps to expliclity create new videoconf discussions, they can only use the id of discussions created by rocket.chat and store them to maybe reuse the same discussion in multiple conferences.
Why? 🤔
Links 🌎
PPC-13
RC Core PR #32793
ADR 92
PS 👀