Merged
Conversation
diegolmello
requested changes
Feb 9, 2021
Member
diegolmello
left a comment
diegolmello
left a comment
There was a problem hiding this comment.
Can you add stories for that?
diegolmello
reviewed
Aug 24, 2021
diegolmello
requested changes
Aug 27, 2021
storybook/stories/Assorted.js
Outdated
| import { View } from 'react-native'; | ||
| import TextInput from '../../app/containers/TextInput'; | ||
|
|
||
| const stories = storiesOf('AssortedItems', module); |
Member
There was a problem hiding this comment.
This is not a good practice imo.
We should add this test for the TextInput instead of calling "Assorted"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
On iOS when we combine the
textAlignproperty with theheight(with a value higher than the default) onTextInput, it tends to create an unexpected break line, causing it to look as ifmultilinewas set totrue. In order to fix this (without affecting i18n) we changed the propertypaddingHorizontaltopadding.Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments