[NEW] Add recording, uploading activity indicators by sumukhah · Pull Request #3243 · RocketChat/Rocket.Chat.ReactNative

sumukhah · 2021-06-28T14:58:15Z

Setup #222392 on server.

Recording, Uploading activities

Screen.Recording.2021-11-22.at.23.00.01.mov

Thread activities

Screen.Recording.2021-11-22.at.23.01.23.mov

Proposed changes

Issue(s)

How to test or reproduce

First of all, you need to check which version type of the server you are on. If you are in the servers with a version equal to or greater than 4.0.0 the indicators will appear as demonstrated in the video, and will happen for rooms and threads. Adding to this, the test plan is:

You should be logged with 2 different accounts into different devices.
Then go to the same room, with both users
And when you are typing/recording/uploading with one account, should appear the same indicator to the other user
Besides, if you are uploading a bigger file and in parallel is typing, the other user should read that: you are uploading, you are typing
And vice versa too

Although, if you are on a server with a version less than 4.0.0 the indicators should occur just into rooms and only for typing

Screenshots

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

web app integration

#222327

lgtm-com · 2021-06-28T15:10:40Z

This pull request introduces 1 alert when merging 2faf9b2 into a6ded95 - view on LGTM.com

new alerts:

1 for Expression has no effect

code clean up mainly on userActivity reducer, Since adding or removing activity indicators share same logic.

…indicators

sumukhah · 2021-07-29T14:38:41Z

app/lib/methods/subscriptions/room.js

+			if (this.actionTimeouts?.[roomId]) {
+				clearTimeout(this.actionTimeouts[roomId]);
+				delete this.actionTimeouts[roomId];
+			}


is this the correct way?

sumukhah · 2021-07-29T14:39:14Z

app/sagas/room.js

+	if (id in activityRenews && status === true) {
+		yield delay(2000);
+	}


Is it a correct way of limiting server requests?

@diegolmello I think only you or your team can answer here, I don't have that knowledge

rodrigok · 2021-08-03T21:15:49Z

app/lib/rocketchat.js

 		const { user } = login;
 		const name = UI_Use_Real_Name ? user.name : user.username;
-		return this.methodCall('stream-notify-room', `${ room }/typing`, name, typing);
+		const stream = Use_New_Activity_Indicators ? 'user-activity' : 'typing';


Should emit both if you accept my comment on the other PR

Maybe we can make the backend control this and emit the old event as well if the setting is enabled. Something to check

Here you need to check the server version and only emit the new event when the connected server is the version containing this improvement. We still don't know when it will be released but you can keep a specific number and make a note in the PR's description to update it when we have the right info.

app/containers/RoomHeader/RoomHeader.js

rodrigok · 2021-08-03T21:27:36Z

app/containers/RoomHeader/RoomHeader.js

+		return <ActivityIndicator action='uploading' users={users} />;
+	}
+
+	return null;


Suggested change

return null;

return;

But it is a component. 'return;' is not returning the "null", getting an error with eslint.

app/containers/RoomHeader/RoomHeader.js

app/sagas/room.js

rodrigok · 2021-08-03T21:36:35Z

app/sagas/room.js

+	if (id in activityRenews && status === true) {
+		yield delay(2000);
+	}


@diegolmello I think only you or your team can answer here, I don't have that knowledge

app/lib/methods/subscriptions/room.js

Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>

Handle both versions of activities, code optimization

rodrigok · 2021-09-23T20:17:41Z

I've changed the event format, need to update this PR

sumukhah · 2021-09-24T08:39:01Z

okay I'll update it very soon

lgtm-com · 2021-09-30T15:16:59Z

This pull request introduces 5 alerts when merging b7792c9 into 5bb5d54 - view on LGTM.com

new alerts:

4 for Unused variable, import, function or class
1 for Invocation of non-function

diegolmello · 2021-12-09T17:40:21Z

app/actions/usersActivity.js

+	};
+}
+
+export function clearUserActivity(username, rid, tmid) {


Missing activity

diegolmello · 2021-12-09T18:17:53Z

app/reducers/usersActivity.js

+		case USERS_ACTIVITY.ADD:
+			if (state[roomId]) {
+				const obj = state[roomId];
+				delete obj[username];


Reducers should not mutate the state https://redux.js.org/usage/structuring-reducers/prerequisite-concepts

This line of code was making events forEach to be unpredictable https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/3243/files#diff-67b9b270a5ff6f8faa4f97992f40a09631edb29f76b5201cb83d491566bc006aR131

…se (allow multiple uploads)

lgtm-com · 2021-12-21T13:14:39Z

This pull request introduces 4 alerts when merging 603dd06 into b75e192 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class
2 for Invocation of non-function

lgtm-com · 2021-12-21T13:22:01Z

This pull request introduces 5 alerts when merging 6913f1a into b75e192 - view on LGTM.com

new alerts:

3 for Unused variable, import, function or class
2 for Invocation of non-function

lgtm-com · 2021-12-22T14:50:34Z

This pull request introduces 5 alerts when merging e490d94 into b75e192 - view on LGTM.com

new alerts:

3 for Unused variable, import, function or class
2 for Invocation of non-function

sumukhah changed the title ~~[NEW] Add thread activity indicators~~ [NEW] Add recording, uploading activity indicators Jun 28, 2021

[NEW] Add uploading, recording activity indicator

2faf9b2

sumukhah force-pushed the activity-indicator branch from 5c71f29 to 2faf9b2 Compare June 28, 2021 15:04

sumukhah mentioned this pull request Jun 28, 2021

[Update] Handle all user activity with user-activity end point RocketChat/Rocket.Chat.js.SDK#139

Closed

sumukhah added 5 commits July 6, 2021 18:00

[NEW]Show thread only activity indicators

2cef8af

[FIX]Uploading and recording indicators not showing on threads

ce2483e

Minor clean up, optimization

a9b6350

[FIX] On closing rooms, activities don't clear

5002d20

code cleanup and optimization, DRY

6d73e52

code clean up mainly on userActivity reducer, Since adding or removing activity indicators share same logic.

sumukhah mentioned this pull request Jul 28, 2021

[NEW] Add activity indicators for Uploading and Recording using new API; Support thread context; Deprecate the old typing API RocketChat/Rocket.Chat#22392

Merged

sumukhah added 2 commits July 29, 2021 19:43

[FIX] Too many server requests from recording and uploading activity …

9538081

…indicators

[FIX] action does not timeout on client(mobile) side

f08ff62

sumukhah commented Jul 29, 2021

View reviewed changes

Adopt compatiblity with the previous typing version of the codebase

a21b1f7

rodrigok requested changes Aug 3, 2021

View reviewed changes

sumukhah and others added 4 commits August 4, 2021 16:21

Apply suggestions from code review

fe2ef4a

Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>

Minor fix

4ee0d91

Handle both versions of activities, code optimization

styling, minor code fix

0d45ed8

Update snapshots

39bdbb8

sumukhah force-pushed the activity-indicator branch 2 times, most recently from ec37259 to 39bdbb8 Compare September 25, 2021 14:38

sumukhah and others added 2 commits September 29, 2021 01:00

Merge branch 'develop' into activity-indicator

89c6537

Merge branch 'develop' into activity-indicator

20f4164

sumukhah force-pushed the activity-indicator branch from b7792c9 to 448cf94 Compare September 30, 2021 15:21

Use new activity indicator API

a2a8b6a

diegolmello added 4 commits December 9, 2021 14:11

Simplify logic

adcbe6b

Catch error

01bf6dd

Remove unnecessary condition

2e2d4bf

Rename events -> activities

ab8b34b

diegolmello reviewed Dec 9, 2021

View reviewed changes

app/actions/usersActivity.js

};

}

export function clearUserActivity(username, rid, tmid) {

Copy link

Member

diegolmello Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing activity

diegolmello reviewed Dec 9, 2021

View reviewed changes

diegolmello added 17 commits December 9, 2021 15:23

Fix user activity add reducer

6a190df

Refactor user activity stream event

15a15ee

Remove confusing comments

45be2ce

Create Upload class

8cf348a

private intervals

1997f72

Remove redux from Upload

d481550

Don't emit false if there's another file being uploaded

26e7624

start/stop uploading methods

02dff13

Sending one emit at time and control when the emitter should send fal…

795a568

…se (allow multiple uploads)

IFileInfo

3fcd8b6

Remove redux from Upload.ts

34dbdc1

roomKey

48b798e

Typo

2e2c8f6

Cleanup

a1e6855

Send multiple files from ShareView

30f513a

Fix Try Again

bd1a00b

Fix upload to thread from ShareView

603dd06

Cleanup

6913f1a

diegolmello added 2 commits December 21, 2021 17:51

Rename Upload to UserActivity

4cabe6e

Move recording/typing to UserActivity

e490d94

diegolmello closed this Feb 3, 2023

Comments

Conversation

sumukhah commented Jun 28, 2021 • edited by reinaldonetof Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Recording, Uploading activities

Thread activities

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Further comments

web app integration

Uh oh!

lgtm-com bot commented Jun 28, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sumukhah Aug 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rodrigok commented Sep 23, 2021

Uh oh!

sumukhah commented Sep 24, 2021

Uh oh!

lgtm-com bot commented Sep 30, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Dec 21, 2021

Uh oh!

lgtm-com bot commented Dec 21, 2021

Uh oh!

lgtm-com bot commented Dec 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sumukhah commented Jun 28, 2021 •

edited by reinaldonetof

Loading

sumukhah Aug 4, 2021 •

edited

Loading