[FIX] Enable face id after re-login if was enabled before#3247
Closed
reinaldonetof wants to merge 13 commits intodevelopfrom
Closed
[FIX] Enable face id after re-login if was enabled before#3247reinaldonetof wants to merge 13 commits intodevelopfrom
reinaldonetof wants to merge 13 commits intodevelopfrom
Conversation
diegolmello
requested changes
Oct 14, 2021
Member
There was a problem hiding this comment.
- I'm missing a more detailed explanation of what it's the current behavior and what you're trying to do. Can you add comments on the code explaining what you're doing? (It can be as GIthub comments... no need to actually right on the code).
- Can you write a proper test plan? Example: what happens if the user updates from version 1 to version 2? Is the app going to allow them to see messages?
- Can we write regression tests?
app/utils/localAuthentication.js
Outdated
| serverRecord = await serversCollection.find(server); | ||
|
|
||
| const { storedAutoLock, storedAutoLockTime, storedBiometry } = await checkAutoLockAndTime(server); | ||
| await serversDB.action(async () => { |
Member
There was a problem hiding this comment.
I didn't get what we're trying to do here.
Aren't we migrating to MMKV?
Contributor
Author
There was a problem hiding this comment.
I needed to do that because when we are starting the app the getSettings is called and the serverInfoUpdate uses the data from the watermelonDB. When I proposed these changes I didn't change the getSettings, but what do you think about it?
diegolmello
requested changes
Dec 9, 2021
Member
diegolmello
left a comment
There was a problem hiding this comment.
FaceID is an iOS feature only and it's not available to all devices.
Some of them might have TouchID only, for example.
The same value is going to be used on Android devices.
We need to call it biometry as it's used on other places.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The current behavior of screen lock:
Go to settings, and active unlock with a passcode, you confirm the passcode and if your phone has biometry or face id you could select them to unlock the app too. When you do a re-login and activate again the screen lock, your configurations will be the default, nevertheless, the passcode continues the same as before.
This purpose introduces a fix to that bug #3102, besides maintaining the data that the user modifications to a specific server, like: in server
Athe user set that there is a screen lock, that could unlock with face id and the time is 1 minute, if the user adds and does a login in a serverB, the screen lock will appear again only when he tries to open the serverA, but if he continues with the serverBand didn't activate the screen lock, the screen lock won't appear.One important thing to report is that the password/passcode will be the same for the whole app.
Issue(s)
Closes #3102 - face id remains off after re-login
How to test or reproduce
Settings > Security and privacy > Screen LockUnlock with PasscodeUnlock with FaceIDUnlock with PasscodeandUnlock with FaceIDneeds to be enabled tooScreenshots
Types of changes
Checklist
Further comments
Closes #3102