[NEW] Add Discussions to RoomActionsView#3287
Merged
Conversation
|
This pull request introduces 1 alert when merging daba3b4 into 91f770c - view on LGTM.com new alerts:
|
Contributor
|
@gerzonc, As discussed in a meeting, it will be necessary to include the discussion menu also in direct message users. Let me know when I can review again. |
diegolmello
requested changes
Jan 21, 2022
| ); | ||
| }; | ||
|
|
||
| export default DiscussionDetails; |
Member
There was a problem hiding this comment.
We should evaluate this later with UX team if we can reuse it on Message component, like we do with Threads.
…ussionDetails component, add useLayoutEffect at DiscussionsView
diegolmello
approved these changes
Jan 27, 2022
…om/RocketChat/Rocket.Chat.ReactNative into new.add-discusions-roomactionsview
10 tasks
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
…-roomactionsview [NEW] Add Discussions to RoomActionsView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently there is no way to see all the discussions created on a room. This PR achieve this by adding a
Discussionsaction toRoomActionsViewwhich shows all the existing Discussions in a room.Issue(s)
Closes #3549
How to test or reproduce
In order to test this you should have a room (channel or group) with at least one discussion
You should be able to see a Discussions item
Screenshots
Types of changes
Checklist
Further comments