Skip to content

Comments

Regression: Orientation lock on Android not working#3345

Merged
diegolmello merged 5 commits intodevelopfrom
regression.orientation-ignored-android
Aug 27, 2021
Merged

Regression: Orientation lock on Android not working#3345
diegolmello merged 5 commits intodevelopfrom
regression.orientation-ignored-android

Conversation

@gerzonc
Copy link
Contributor

@gerzonc gerzonc commented Aug 25, 2021

Proposed changes

Latest versions from react-nativate-orientation-locker doesn't seem to respect orientation lock from device. For now we will just go back to the previous version we had.

Issue(s)

Closes #3348

How to test or reproduce

  1. Log in
  2. Lock orientation on device's OS
  3. Turn the device
  4. It should respect the orientation lock and stay in portrait mode

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@AlexAlexandre AlexAlexandre self-requested a review August 27, 2021 16:30
@diegolmello diegolmello merged commit 0a55467 into develop Aug 27, 2021
@diegolmello diegolmello deleted the regression.orientation-ignored-android branch August 27, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rotation lock ignored in latest Android version (23rd August)

2 participants