[IMPROVE] Onboarding changes by reinaldonetof · Pull Request #3387 · RocketChat/Rocket.Chat.ReactNative

reinaldonetof · 2021-09-17T14:23:07Z

Proposed changes

Change the first screen of the app
Minor changes on NewServerView and make it the first screen of the app
-- This requires a few changes on the stack as well
Add "Create workspace" to ServerDropdown
Update E2E tests

Issue(s)

How to test or reproduce

Open the app without an account
Enter the workspace
Do the login flow
When logged in:
- 1 -> If you logout, you should be redirected to the first page
- 2 -> If Add a server, you must be redirected to the first page

Screenshots

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

e2e/tests/onboarding/01-onboarding.spec.js

diegolmello · 2021-09-17T16:31:55Z

app/views/RoomsListView/ServerDropdown.js

+		try {
+			await Linking.openURL('https://cloud.rocket.chat/trial');
+		} catch {
+			logEvent(events.RL_CREATE_NEW_WORKSPACE_F);


If there's an issue happening, log the error of the issue.

Just remove it and keep log(e) only.
logEvent isn't important here, although you might seen it on some other catches (they are also wrong).
The only important tracking here is the error itself, so we can fix it later.

app/actions/app.js

app/i18n/locales/en.json

app/actions/app.js

app/i18n/locales/en.json

app/sagas/deepLinking.js

app/views/NewServerView/ServerInput/index.js

app/views/NewServerView/index.js

diegolmello · 2021-09-21T20:18:14Z

app/views/OnboardingView/index.js

-	constructor(props) {
-		super(props);
-		if (!isTablet) {
-			Orientation.lockToPortrait();


We need to keep locking orientation

diegolmello · 2021-09-21T20:19:19Z

app/views/OnboardingView/styles.js

-		alignSelf: 'center',
-		marginTop: isTablet ? 0 : verticalScale(116),
-		marginBottom: verticalScale(50),
-		maxHeight: verticalScale(150),


If we stick to scaling, remember to do it on render instead.
There was an issue when the app was started on landscape and styles calculated on styles.js.

diegolmello · 2021-09-21T20:21:15Z

app/views/RoomsListView/ServerDropdown.js

+		try {
+			await Linking.openURL('https://cloud.rocket.chat/trial');
+		} catch {
+			logEvent(events.RL_CREATE_NEW_WORKSPACE_F);


Just remove it and keep log(e) only.
logEvent isn't important here, although you might seen it on some other catches (they are also wrong).
The only important tracking here is the error itself, so we can fix it later.

…hat.ReactNative into new.create-workspace

lgtm-com · 2021-09-21T21:24:36Z

This pull request introduces 1 alert when merging 996b324 into 0871849 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

…Rocket.Chat.ReactNative into new.create-workspace

lgtm-com · 2021-09-22T14:59:03Z

This pull request introduces 2 alerts when merging db30859 into 0871849 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-09-22T17:13:31Z

This pull request introduces 2 alerts when merging 0e43cb0 into 0871849 - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

lgtm-com · 2021-09-22T23:05:42Z

This pull request introduces 2 alerts when merging 7dfa547 into a52199a - view on LGTM.com

new alerts:

2 for Unused variable, import, function or class

…Rocket.Chat.ReactNative into new.create-workspace

…hat.ReactNative into new.create-workspace

diegolmello · 2021-09-23T14:05:12Z

Made a small change on NewServerView

diegolmello

LGTM! 🚀

- Change the first screen of the app - Minor changes on NewServerView and make it the first screen of the app - Add "Create workspace" to ServerDropdown Co-authored-by: Diego Mello <diegolmello@gmail.com>

reinaldonetof added 2 commits September 14, 2021 19:33

move create workspace button to dropdown

6008b9c

Fix new server view

1a63e80

reinaldonetof self-assigned this Sep 17, 2021

reinaldonetof added the 🚧 wip label Sep 17, 2021

reinaldonetof and others added 5 commits September 17, 2021 11:56

Merge branch 'develop' into new.create-workspace

5e3eddc

Merge branch 'develop' into new.create-workspace

06ca560

clean up ROOT_OUTSIDE

c57caaf

minor tweaks and removed onboardingview

9449949

minor tweak on onboarding image

8d5137c

diegolmello requested changes Sep 17, 2021

View reviewed changes

minor tweaks

9ed35f0

reinaldonetof added 👀 needs review 🛠 fix and removed 🚧 wip labels Sep 17, 2021

reinaldonetof and others added 3 commits September 21, 2021 16:17

cancel add server

fa87dc6

Merge branch 'develop' into new.create-workspace

d6f9d1d

Decrease create workspace button height

38b8415

diegolmello requested changes Sep 21, 2021

View reviewed changes

reinaldonetof and others added 4 commits September 21, 2021 17:52

minor tweaks

cd583bb

minor tweaks dropdown height

72b6034

Fix scaling

e01c31d

Merge branch 'new.create-workspace' of github.com:RocketChat/Rocket.C…

996b324

…hat.ReactNative into new.create-workspace

reinaldonetof and others added 7 commits September 21, 2021 19:52

fix the finish add

f7ef6c6

Merge branch 'new.create-workspace' of https://github.com/RocketChat/…

a33eeee

…Rocket.Chat.ReactNative into new.create-workspace

removed root_new_server

64f4cc3

Remove server.adding

943e179

Fix key command

b7e075d

Calling serverFinishAdd on NewServerView.unmount

0963706

Cleanup

db30859

diegolmello approved these changes Sep 22, 2021

View reviewed changes

minor tweaks

0e43cb0

reinaldonetof and others added 3 commits September 22, 2021 19:51

minor tweaks on margins

abd7173

Merge branch 'develop' into new.create-workspace

249a7f7

storyshot updated

7dfa547

reinaldonetof and others added 6 commits September 23, 2021 09:37

clean unused

307467c

Merge branch 'develop' into new.create-workspace

4401c59

removed join-workspace from detox test

e7f3001

Merge branch 'new.create-workspace' of https://github.com/RocketChat/…

608a472

…Rocket.Chat.ReactNative into new.create-workspace

Small layout change

f948206

Merge branch 'new.create-workspace' of github.com:RocketChat/Rocket.C…

79ebbc8

…hat.ReactNative into new.create-workspace

diegolmello changed the title ~~[FIX] Onboarding view changes~~ [IMPROVE] Onboarding changes Sep 23, 2021

diegolmello approved these changes Sep 23, 2021

View reviewed changes

diegolmello merged commit d2544a7 into develop Sep 23, 2021

diegolmello deleted the new.create-workspace branch September 23, 2021 14:17

Comments

Conversation

reinaldonetof commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Further comments

Uh oh!

Uh oh!

diegolmello Sep 17, 2021

Choose a reason for hiding this comment

Uh oh!

diegolmello Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

diegolmello Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

diegolmello Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

diegolmello Sep 21, 2021

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Sep 21, 2021

Uh oh!

lgtm-com bot commented Sep 22, 2021

Uh oh!

lgtm-com bot commented Sep 22, 2021

Uh oh!

lgtm-com bot commented Sep 22, 2021

Uh oh!

diegolmello commented Sep 23, 2021

Uh oh!

diegolmello left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

reinaldonetof commented Sep 17, 2021 •

edited

Loading