[FIX] Preserve voice message if recording is interrupted#3397
Merged
diegolmello merged 2 commits intodevelopfrom Sep 23, 2021
Merged
[FIX] Preserve voice message if recording is interrupted#3397diegolmello merged 2 commits intodevelopfrom
diegolmello merged 2 commits intodevelopfrom
Conversation
…ts/7c259096713a73e4e39467b45298222ca16a9d5e
10 tasks
71087ca to
25cfe47
Compare
Member
Author
|
@jacotec LGTM! Thanks for your contribution! I only fixed a couple of things and removed the pause icon. |
Contributor
|
@diegolmello Great, thanks! I'm fine to remove the pause icon ;-) |
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
…3397) * RocketChat@7c25909 * Minor changes Co-authored-by: Marco Jakobs <mj@jacotec.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Proposed changes
When an event interrupts an ongoing voice recording in IOS, the OS stops the recording. This was not handled properly before: The message was immediately completely lost and it was not possible to make a new voice message before force-quitting and restarting the app (because the Expo recorder was left in loaded state).
This PR stops the recording in this case, indicating it was stopped. The user can send or discard the voice message up to that point at any time afterwards.
I also changed the GUI to make it more clear. See below.
Issue(s)
#3002
#3388
How to test or reproduce
New behavior
Old behavior
Screenshots
Record in progress: I've replaced the red cross and green check by a red trash icon and a green send icon. IMHO this is much more clear: The green icon in fact immediately sends the message, the red icon immediately trashes the message (all my users highly appreciate this change as well).

Behind the time display the "record" symbol states that the recording is running.
This is an incoming call. As soon as IOS stops the recording, I'll indicate this with the "pause" symbol behind the time display. The time is stopped and shows the length of the message.

After the call was finished, you can still send or trash the waiting message at any time:

Types of changes
Checklist
Further comments
Would be fine to have this in the next release together with my previous fix merge to have the voice message fixes complete.