Skip to content

Comments

[FIX] Room Actions buttons not showing after taking a channel from Omnichannel Queue#3399

Merged
diegolmello merged 3 commits intodevelopfrom
fix.omnichannel-rooom-actions
Sep 28, 2021
Merged

[FIX] Room Actions buttons not showing after taking a channel from Omnichannel Queue#3399
diegolmello merged 3 commits intodevelopfrom
fix.omnichannel-rooom-actions

Conversation

@reinaldonetof
Copy link
Contributor

Proposed changes

After an agent opens a chat from Omnichannel's queue, then Take It and goes to Actions view, the omnichannel's buttons didn't appear properly. So this PR pass the param joined from Room view to Actions view to test if all the omnichannel's buttons should appear.

Issue(s)

How to test or reproduce

  • You need to be an agent from omnichannel
  • Go to the Omnichannel's queue, open one room
  • Go to
  • Now, you are the agent that

Screenshots

BEFORE

134568700-ba2ffeb6-4d88-4478-b6e3-86371bfcee0d.mp4

AFTER

134568905-6f7d88ba-726d-44eb-9ddb-ebf9b474dcb3.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diegolmello diegolmello changed the title [FIX] Room Actions buttons after Take It from Omnichannel's Queue [FIX] Room Actions buttons not showing after taking a channel from Omnichannel Queue Sep 24, 2021
@diegolmello diegolmello merged commit c5df938 into develop Sep 28, 2021
@diegolmello diegolmello deleted the fix.omnichannel-rooom-actions branch September 28, 2021 19:33
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…nichannel Queue (RocketChat#3399)

Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants