[IMPROVE] Open Jitsi call even if server isn't found#3442
Merged
diegolmello merged 6 commits intodevelopfrom Nov 16, 2021
Merged
[IMPROVE] Open Jitsi call even if server isn't found#3442diegolmello merged 6 commits intodevelopfrom
diegolmello merged 6 commits intodevelopfrom
Conversation
AlexAlexandre
changed the title
diegolmello
requested changes
Oct 26, 2021
app/lib/methods/callJitsi.js
Outdated
| logEvent(events.RA_JITSI_VIDEO); | ||
| const { Jitsi_Domain, Jitsi_SSL } = reduxStore.getState().settings; | ||
| const protocol = Jitsi_SSL ? 'https://' : 'http://'; | ||
| const url = `${protocol}${Jitsi_Domain}/${path}`; |
Member
There was a problem hiding this comment.
Idk about this one.
The goal of the PR is to do a fallback, but here we're assuming they're on the right server, which might not be the case.
Example:
- App is connected to a server with
Jitsi_Domainpointing to their own Jitsi server (other.jitsi.server) - App receives a msg requiring a fallback (https://jitsi.rocket.chat/not-a-proper-path)
- The current PR would try to open https://other.jitsi.server/not-a-proper-path instead of the link pressed
Contributor
Author
There was a problem hiding this comment.
Nice catch! I didn't know that was possible.
To do that, I needed to pass the full url to the deepLinking function, today we pass just the path.
with the full url, I just call the function to open the meeting.
What do you think about this solution ?
diegolmello
approved these changes
Nov 10, 2021
diegolmello
changed the title
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The purpose of this PR is to implement a new flow for Jitsi Meetings.
Today, the mobile app can only open meeting rooms from known servers. When we tap a Jitsi URL or the app is opened from deep link, we use the Jitsi URL pattern to identify the server, connect to it and only then we open the call.
A new flow was requested to open Jitsi meetings even we do not find the server.
Issue(s)
N/A
How to test or reproduce
To test the new behaviour, will be necessary create a Jitsi meet with a random url, for example
https://jitsi.rocket.chat/test-call, Send as a link on a chat, tap this link and then a meeting room should open normally.For a regression test, try opening some normal meeting rooms, for example:
everything needs works normally
Screenshots
Before
jetsiMeeting-before.mov
After
jetsiMeeting-after.mov
Types of changes
Checklist
Further comments
N/A