Skip to content

Comments

Chore: Migrate UserNotificationPreferencesView to Typescript#3469

Merged
diegolmello merged 4 commits intodevelopfrom
chore.ts-user-notification-preference
Nov 16, 2021
Merged

Chore: Migrate UserNotificationPreferencesView to Typescript#3469
diegolmello merged 4 commits intodevelopfrom
chore.ts-user-notification-preference

Conversation

@reinaldonetof
Copy link
Contributor

Proposed changes

Issue(s)

How to test or reproduce

Go to Profile, then click on Notifications and will appear the Notification Preferences

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 8e55032 into develop Nov 16, 2021
@diegolmello diegolmello deleted the chore.ts-user-notification-preference branch November 16, 2021 16:16
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…hat#3469)

Co-authored-by: AlexAlexandre <alexalexandrejr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants