Skip to content

Chore: Migrate ShareView to Typescript#3481

Merged
diegolmello merged 5 commits intodevelopfrom
chore.ts-shareview
Nov 16, 2021
Merged

Chore: Migrate ShareView to Typescript#3481
diegolmello merged 5 commits intodevelopfrom
chore.ts-shareview

Conversation

@reinaldonetof
Copy link
Contributor

@reinaldonetof reinaldonetof commented Nov 4, 2021

Proposed changes

Issue(s)

How to test or reproduce

  • Try to share something with the Rocket Chat App.
  • Test sharing only one file and with multiple files too
  • Also you should be able to share files with your previous conversations
  • Check if the thumb attachment and preview attachment are showing correctly
  • Furthermore, check if the Attachment View to see images inside the normal app is working properly

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@AlexAlexandre
Copy link
Contributor

AlexAlexandre commented Nov 10, 2021

For everyone's knowledge, here is a link about changing the .ios.tsx and .android.tsx files

https://stackoverflow.com/a/59972215

#3459 (comment)

Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 2b3542d into develop Nov 16, 2021
@diegolmello diegolmello deleted the chore.ts-shareview branch November 16, 2021 16:19
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments