Skip to content

Comments

Chore: Migrate ChangePasscodeView to Typescript#3482

Merged
diegolmello merged 2 commits intodevelopfrom
chore.ts-changepasscodeview
Nov 10, 2021
Merged

Chore: Migrate ChangePasscodeView to Typescript#3482
diegolmello merged 2 commits intodevelopfrom
chore.ts-changepasscodeview

Conversation

@reinaldonetof
Copy link
Contributor

Proposed changes

Issue(s)

How to test or reproduce

  • Go to Security and Privacy
  • Enable the Unlock with Passcode, if is your first time unlocking with the passcode you will insert the passcode normally
  • Then will appear a button Change Passcode, that will pop up a modal to you insert the passcode
  • All functionalities should work properly.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 138f0ab into develop Nov 10, 2021
@diegolmello diegolmello deleted the chore.ts-changepasscodeview branch November 10, 2021 20:50
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants