Skip to content

Comments

Chore: Migrate CreateChannelView to Typescript#3486

Merged
diegolmello merged 4 commits intodevelopfrom
chore.ts-createchannelview
Nov 10, 2021
Merged

Chore: Migrate CreateChannelView to Typescript#3486
diegolmello merged 4 commits intodevelopfrom
chore.ts-createchannelview

Conversation

@reinaldonetof
Copy link
Contributor

Proposed changes

Issue(s)

How to test or reproduce

  • Create a channel or a team
  • Select users
  • And when you click Next, this is the View that we are migrating here

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Copy link
Contributor

@AlexAlexandre AlexAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@diegolmello diegolmello merged commit 3249c54 into develop Nov 10, 2021
@diegolmello diegolmello deleted the chore.ts-createchannelview branch November 10, 2021 21:18
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Co-authored-by: AlexAlexandre <alexalexandrejr@gmail.com>
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants