Skip to content

[IMPROVEMENT] Fixed Unsafe Cryptographic Encryption Mode#3530

Closed
daniilr wants to merge 1 commit intoRocketChat:developfrom
daniilr:hotfix/unsafe-cryptographic-develop
Closed

[IMPROVEMENT] Fixed Unsafe Cryptographic Encryption Mode#3530
daniilr wants to merge 1 commit intoRocketChat:developfrom
daniilr:hotfix/unsafe-cryptographic-develop

Conversation

@daniilr
Copy link

@daniilr daniilr commented Nov 29, 2021

Proposed changes

This PR fixes issue mentioned in #3525. As recommended in google documentation, encryption methods were rewritten to use AES/GCM/NoPadding. Besides that, deprecated com.scottyab:secure-preferences-lib was replaced with safer androidx.security:security-crypto

Issue(s)

react-native-mmkv-storage dependency use unsafe chiper encryption mode. It doesn't comply with google recomendations

How to test or reproduce

Upload bundle to Google Play Store. It will not pass security checks.

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

@diegolmello
Copy link
Member

We just merged #3634. Let's see if it fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments