Skip to content

Chore: Change console.log to console.error on log()#3652

Merged
reinaldonetof merged 2 commits intodevelopfrom
chore.console-error
Feb 4, 2022
Merged

Chore: Change console.log to console.error on log()#3652
reinaldonetof merged 2 commits intodevelopfrom
chore.console-error

Conversation

@reinaldonetof
Copy link
Contributor

Proposed changes

Log red screen error as console.error instead console.log and show the error properly

Issue(s)

How to test or reproduce

This test plan is to developers:

  • Open the Reactotron and connect with the emulator
  • Go to
    const { onEmojiSelected } = this.props;
  • Insert a code as const e = emoji.content.test.emoji and save
  • Then open the open.rocket.chat, inside any room, do a long press on any message, click on emoji with plus signal, and tap on any emoji.
  • On Reactotron will appear a line with { } - this is the error returned, but Reactotron can't understand
  • Then, use this branch, do the same steps, and will alert on Reactotron something with ERROR

Screenshots

Before

Screen Shot 2022-01-26 at 00 19 10

After

Screen Shot 2022-01-26 at 00 17 38

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello changed the title Chore: Change console.log to console.error when logging error Chore: Change console.log to console.error on log() Jan 26, 2022
@reinaldonetof reinaldonetof merged commit f9b94df into develop Feb 4, 2022
@reinaldonetof reinaldonetof deleted the chore.console-error branch February 4, 2022 18:22
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Chore: Change console.log to console.error on log()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments