Chore: Change console.log to console.error on log()#3652
Merged
reinaldonetof merged 2 commits intodevelopfrom Feb 4, 2022
Merged
Chore: Change console.log to console.error on log()#3652reinaldonetof merged 2 commits intodevelopfrom
reinaldonetof merged 2 commits intodevelopfrom
Conversation
diegolmello
approved these changes
Jan 26, 2022
ivnxyz
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
Chore: Change console.log to console.error on log()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Log red screen error as
console.errorinsteadconsole.logand show the error properlyIssue(s)
How to test or reproduce
This test plan is to developers:
Rocket.Chat.ReactNative/app/containers/EmojiPicker/index.tsx
Line 88 in 782bdda
const e = emoji.content.test.emojiand saveopen.rocket.chat, inside any room, do a long press on any message, click on emoji with plus signal, and tap on any emoji.{ }- this is the error returned, but Reactotron can't understandERRORScreenshots
Before
After
Types of changes
Checklist
Further comments