[FIX] Leave room request not removing the subscription from the app#3757
Closed
cking-vonix wants to merge 1 commit intoRocketChat:developfrom
Closed
[FIX] Leave room request not removing the subscription from the app#3757cking-vonix wants to merge 1 commit intoRocketChat:developfrom
cking-vonix wants to merge 1 commit intoRocketChat:developfrom
Conversation
When a subscription is removed from the server via another client, when the mobile app is relaunched the subscriptions were not being removed properly. Changed the logic to use the subscriptionResult.remove array from the server and the _id property to fix.
Member
|
Nice fix! We're going to QA it soon. Thanks! |
10 tasks
diegolmello
approved these changes
Mar 11, 2022
Member
|
We can't update your branch, because it's from an org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When a subscription is removed from the server via another client, when the
mobile app is relaunched the subscriptions were not being removed properly.
Changed the logic to use the subscriptionResult.remove array from the server
and the _id property to fix.
Issue(s)
#3756
How to test or reproduce
Steps to reproduce same as in issue:
Screenshots
Types of changes
Checklist
Further comments