Skip to content

Comments

[FIX] Leave room request not removing the subscription from the app#3757

Closed
cking-vonix wants to merge 1 commit intoRocketChat:developfrom
vonix-networks:bugfix/subscription-sync
Closed

[FIX] Leave room request not removing the subscription from the app#3757
cking-vonix wants to merge 1 commit intoRocketChat:developfrom
vonix-networks:bugfix/subscription-sync

Conversation

@cking-vonix
Copy link
Contributor

Proposed changes

When a subscription is removed from the server via another client, when the
mobile app is relaunched the subscriptions were not being removed properly.
Changed the logic to use the subscriptionResult.remove array from the server
and the _id property to fix.

Issue(s)

#3756

How to test or reproduce

Steps to reproduce same as in issue:

  • Open mobile application and login to initialize database
  • Close the app completely
  • Login via web to same account and leave (not delete) a room to remove the subscription for that user.
  • Re-open mobile application and the room that was left still exists

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

When a subscription is removed from the server via another client, when the
mobile app is relaunched the subscriptions were not being removed properly.
Changed the logic to use the subscriptionResult.remove array from the server
and the _id property to fix.
@diegolmello
Copy link
Member

Nice fix! We're going to QA it soon. Thanks!

@diegolmello diegolmello changed the title [FIX] Fix synchronization of removed subscriptions [FIX] Leave room request not removing the subscription from the app Feb 22, 2022
@diegolmello
Copy link
Member

We can't update your branch, because it's from an org.
We merged at #3768 though.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants