Skip to content

[FIX] Fix auto complete regex expression#3777

Closed
dnlsilva wants to merge 3 commits intodevelopfrom
fix/autocomplete-dont-clear-search-query
Closed

[FIX] Fix auto complete regex expression#3777
dnlsilva wants to merge 3 commits intodevelopfrom
fix/autocomplete-dont-clear-search-query

Conversation

@dnlsilva
Copy link
Contributor

@dnlsilva dnlsilva commented Feb 24, 2022

Proposed changes

Issue(s)

Add Cyrillic alphabet to auto complete regex expression

How to test or reproduce

Mention a user in a chat using the Cyrillic alphabet, autocomplete should erase the characters used to find the user and keep only the name.

Screenshots

Without the fix:

Screen.Recording.2022-02-24.at.17.51.54.mov

With the fix:

Screen.Recording.2022-02-24.at.17.52.52.mov

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@dnlsilva dnlsilva changed the title [FIX] Add Cyrillic alphabet to auto complete regex expression [FIX] Fix auto complete regex expression Feb 24, 2022
@try-catch-stack
Copy link
Contributor

try-catch-stack commented Feb 25, 2022

I also made a PR #3696 but as @diegolmello pointed , it was not working on iOS . So I have updated the regex in the PR .Can you please take a look at it?

Check Regex test .

@dnlsilva
Copy link
Contributor Author

I also made a PR #3696 but as @diegolmello pointed , it was not working on iOS . So I have updated the regex in the PR .Can you please take a look at it?

Check Regex test .

Yes, he is correct, it is the same as this commit I had made here: e2b11e3
I was testing other things yesterday, but it didn't work out very well :).

@dnlsilva dnlsilva closed this Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments