Skip to content

[FIX] Showing blank screen on share extension if the user is not logged in#4207

Merged
reinaldonetof merged 8 commits intodevelopfrom
fix.share-extension-not-logged
May 27, 2022
Merged

[FIX] Showing blank screen on share extension if the user is not logged in#4207
reinaldonetof merged 8 commits intodevelopfrom
fix.share-extension-not-logged

Conversation

@reinaldonetof
Copy link
Contributor

Proposed changes

Redirect users to WithoutServersView in case there was no logged in server.

Issue(s)

How to test or reproduce

  • Make sure the app is not logged in any server (if you open from app icon, shows onboarding screen)
  • Open Photos or Gallery and try to share a photo using Rocket.Chat

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2022

This pull request introduces 2 alerts when merging 609ec4e into f1f8e95 - view on LGTM.com

new alerts:

  • 2 for Direct state mutation

@diegolmello diegolmello force-pushed the fix.share-extension-not-logged branch from 609ec4e to 0aff967 Compare May 26, 2022 17:54
@lgtm-com
Copy link

lgtm-com bot commented May 26, 2022

This pull request introduces 2 alerts when merging 0aff967 into bc34706 - view on LGTM.com

new alerts:

  • 2 for Direct state mutation

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2022

This pull request introduces 1 alert when merging 0603bc1 into 992e438 - view on LGTM.com

new alerts:

  • 1 for Direct state mutation

@diegolmello diegolmello changed the title [FIX] Redirect not logged users to WithoutServersView [FIX] Showing blank screen on share extension if the user is not logged in May 26, 2022
@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 1 alert when merging 72e00b4 into 992e438 - view on LGTM.com

new alerts:

  • 1 for Direct state mutation

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 1 alert when merging b1e1e47 into 992e438 - view on LGTM.com

new alerts:

  • 1 for Direct state mutation

@reinaldonetof reinaldonetof merged commit 53aaae5 into develop May 27, 2022
@reinaldonetof reinaldonetof deleted the fix.share-extension-not-logged branch May 27, 2022 17:11
diegolmello pushed a commit that referenced this pull request May 30, 2022
…ed in (#4207)

* [FIX] Redirect not logged users to WithoutServersView

* minor tweak

* [FIX] Redirect not logged users to WithoutServersView

* minor tweak

* fix the init

* update yarn.lock

Co-authored-by: Alex Junior <alexalexandrejr@gmail.com>
ivnxyz pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
…ed in (RocketChat#4207)

* [FIX] Redirect not logged users to WithoutServersView

* minor tweak

* [FIX] Redirect not logged users to WithoutServersView

* minor tweak

* fix the init

* update yarn.lock

Co-authored-by: Alex Junior <alexalexandrejr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments