Skip to content

Comments

Added changes to fix the markdown for mention user#5367

Open
brf153 wants to merge 8 commits intoRocketChat:developfrom
brf153:mention_slash_error
Open

Added changes to fix the markdown for mention user#5367
brf153 wants to merge 8 commits intoRocketChat:developfrom
brf153:mention_slash_error

Conversation

@brf153
Copy link
Contributor

@brf153 brf153 commented Nov 27, 2023

Proposed changes

Fixed the bug in the markup so that it now works for user mentions.

Issue(s)

closes #5302
Depends on RocketChat/fuselage#1228

How to test or reproduce

Create a message using various Markdown formatting options and include mentions using '@'. For instance, *Hello @brf153, how are you?*

Screenshots

From
WhatsApp Image 2023-11-27 at 21 59 58

To
WhatsApp Image 2023-11-27 at 21 55 54

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added the necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Additional Comment

I need to add changes to the fuselage repository of Rocket Chat. After that, this pull request will work fine.

@diegolmello
Copy link
Member

Thanks for your contribution, @brf153!
We're going to evaluate this asap.
Just be aware we're in the middle of a long release, so it might take longer than expected to review it.

@brf153
Copy link
Contributor Author

brf153 commented Nov 29, 2023

@diegolmello Sure sir

@Rohit3523
Copy link
Contributor

Rohit3523 commented Mar 5, 2025

@OtavioStasiak, can you please check if this was recently fixed by you in the a11y changes? 👀

@Rohit3523
Copy link
Contributor

I tried to lookup but can't find more about this

@diegolmello
Copy link
Member

@Rohit3523 It could've been fixed by the recent markdown migration. Can you check? Thanks!

@Rohit3523
Copy link
Contributor

Mention is not rendering inside any markdown

Screenshot_2025_0306_180500

Tested on 4.58.0.74631 (Android)

@diegolmello
Copy link
Member

@Rohit3523 is it working on this PR?

@Rohit3523
Copy link
Contributor

Screenshot 2025-03-10 at 8 47 20 PM

I can confirm that this PR fixes the issue, and we only have file import conflicts

@Rohit3523
Copy link
Contributor

Rohit3523 commented Mar 10, 2025

A small issue i just noticed, when we end with mention in italic markdown (_Test @rohit.bansal_), it fails to render the markdown

Screenshot 2025-03-10 at 8 58 45 PM

Nevermind it's backend issue, Getting same behaviour in web version
Screenshot 2025-03-10 at 8 59 48 PM

@Rohit3523 Rohit3523 mentioned this pull request Jan 12, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usernames removed from message using /me

3 participants