Added changes to fix the markdown for mention user#5367
Open
brf153 wants to merge 8 commits intoRocketChat:developfrom
Open
Added changes to fix the markdown for mention user#5367brf153 wants to merge 8 commits intoRocketChat:developfrom
brf153 wants to merge 8 commits intoRocketChat:developfrom
Conversation
Signed-off-by: brf153 <153hsb@gmail.com>
Member
|
Thanks for your contribution, @brf153! |
Contributor
Author
|
@diegolmello Sure sir |
Contributor
|
@OtavioStasiak, can you please check if this was recently fixed by you in the a11y changes? 👀 |
Contributor
|
I tried to lookup but can't find more about this |
Member
|
@Rohit3523 It could've been fixed by the recent markdown migration. Can you check? Thanks! |
Contributor
Member
|
@Rohit3523 is it working on this PR? |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Proposed changes
Fixed the bug in the markup so that it now works for user mentions.
Issue(s)
closes #5302
Depends on RocketChat/fuselage#1228
How to test or reproduce
Create a message using various Markdown formatting options and include mentions using '@'. For instance,
*Hello @brf153, how are you?*Screenshots
From

To

Types of changes
Checklist
Additional Comment
I need to add changes to the fuselage repository of Rocket Chat. After that, this pull request will work fine.