fix: katex array breaking the app#6963
Conversation
WalkthroughThese changes address KaTeX array rendering by introducing block environment detection in the KaTeX component, which short-circuits rendering in display mode instead of delegating through MathView. New story exports are added to demonstrate KaTeX array rendering behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM |
Proposed changes
KaTeX arrays should be rendered using our KaTeX component, not MathView.
Usually, this kind of KaTeX should go to renderError and then be rendered using the KaTeX component. However, MathView is not treating it as an error and is also unable to render it correctly. Because of that, I added a validation to detect arrayKaTeX and render it using the correct component.
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-990
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Summary by CodeRabbit
Bug Fixes
Tests