This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[FIX] Disable LoginServices HTTP request while APIs are broken#1609
Closed
[FIX] Disable LoginServices HTTP request while APIs are broken#1609
Conversation
houndci-bot
reviewed
Apr 26, 2018
| typealias APIResourceType = LoginServicesResource | ||
|
|
||
| let requiredVersion: Version = Version(0, 64, 0) | ||
| // TODO: Re-enable when we have fixed the APIs. |
There was a problem hiding this comment.
Todo Violation: TODOs should be resolved (Re-enable when we have fixed t...). (todo)
Member
Author
|
If merge this PR RocketChat/Rocket.Chat#10596 before 0.64.0 is up, then we can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios