[REGRESSION] Malformed urls for avatar icons when hosted from a subdirectory

[bennlich]

Description:

When rocket chat is hosted from the /chat subdirectory. Avatar icons get requested from broken urls like:

https://my.domain/chat/chat/avatar/%40general?_dc=undefined

I.e. the subdirectory is repeated in the request URL. Seems similar to #10029.

This seems to be a regression. I did not have this problem until I upgraded to 0.65.1 from 0.62.2.

Server Setup Information:

• Version of Rocket.Chat Server: 0.65.1
• Operating System: Ubuntu 14.04
• Deployment Method(snap/docker/tar/etc): tar
• Number of Running Instances: 1
• DB Replicaset Oplog: ?
• Node Version: 8.9.1
• mongoDB Version: 3.6.2

Expected behavior:

Client (web and electron) makes successful request to https://my.domain/chat/avatar/%40general?_dc=undefined.

Actual behavior:

Client (web and electron) makes failed request to https://my.domain/chat/chat/avatar/%40general?_dc=undefined.

[BanHammor]

I'm not sure if I'm getting this bug or not - for me avatars in the chat behave normally, but avatars in the room list do not.

[balcsida]

Hi @bennlich and @BanHammor,

#12365 is merged to master and included in release 0.71.0-rc.0.
It seems that it resolved a similar issue for me.
Do you experience the same thing?

[AshtenThePlatypus]

Hello!

I have Nginx proxying to a subdirectory. The url to connect: domain.com/chat.

Everything loads fine except for these avatars.

I can confirm that this issue still exists in specific situations:

• In the extended view of the channels, the channel/direct message pictures are broken (https:/domain.com/chat/chat/avatar/%40testing?_dc=0)

• Replies or mentions in chats, the avatar of the user that was replied to are broken: (https://domain.com/chat/chat/avatar/davidtheplatypus?_dc=0)

However, other avatars are working:

• Avatars in chat (https://domain.com/chat/avatar/davidtheplatypus?_dc=0)

• Avatars in directory (https://domain.com/chat/avatar/%40general?_dc=0)