[NEW] Changes all 'mergeChannels' to 'groupByType'.#10055
Merged
ggazzo merged 2 commits intoRocketChat:groupByTypefrom May 30, 2018
mikaelmello:develop
Merged
[NEW] Changes all 'mergeChannels' to 'groupByType'.#10055ggazzo merged 2 commits intoRocketChat:groupByTypefrom mikaelmello:develop
ggazzo merged 2 commits intoRocketChat:groupByTypefrom
mikaelmello:develop
Conversation
Modifies boolean logic as necessary.
ggazzo
requested changes
May 25, 2018
Member
ggazzo
left a comment
There was a problem hiding this comment.
@mikaelmello shoud we create a migration? what do you think?
Contributor
Author
|
@ggazzo Yeah probably. If we don't though, the only impact was that this setting is specific would be kind of "reset", is that correct? |
Member
|
something like that, but old servers will keep this useless data forever, and probably some users will complain about loose configs... if you need some help to create a migration I can help :) |
Member
|
@mikaelmello I cant checkout your branch could you add this migration? RocketChat.Migrations.add({
version: 122,
up() {
return RocketChat.models.Users.update({
'settings.preferences.mergeChannels': {
$exists: true
}
}, {
$rename: {
'settings.preferences.mergeChannels': 'settings.preferences.groupByType'
}
}, {
multi: true
});
}
}); |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies boolean logic as necessary.
It keeps logic reported on #10042 even though I still don't understand it yet.
This PR was made because there were comments with a TODO to do this exact change.
@RocketChat/core
https://github.com/RocketChat/docs/pull/621