[NEW] Added endpoint to retrieve mentions of a channel#10105
Merged
[NEW] Added endpoint to retrieve mentions of a channel#10105
Conversation
added endpoint to retrieve all the mentions of a channel
Contributor
Author
|
@rafaelks, could you take a look on this? |
rafaelks
approved these changes
Mar 13, 2018
Contributor
rafaelks
left a comment
rafaelks
left a comment
There was a problem hiding this comment.
LGTM (haven't actually tested the code)!
@MarcosSpessatto The result is a list of messages, right?
Contributor
Author
|
@rafaelks, exactly! |
Contributor
|
Added it to the milestone 👍 |
rodrigok
requested changes
Mar 15, 2018
Member
There was a problem hiding this comment.
Why are you changing the message format?
added pagination to channels.getAllUserMentionsByChannel endpoint.
added 2 commits
March 21, 2018 14:40
…nnel' into feature/rest-api-mentions-of-channel
rodrigok
requested changes
Mar 26, 2018
| } | ||
| })); | ||
|
|
||
| return RocketChat.API.v1.success({ |
Member
There was a problem hiding this comment.
@MarcosSpessatto the other paginated APIs returns more data like:
return RocketChat.API.v1.success({
channels: rooms,
count: rooms.length,
offset,
total: RocketChat.models.Rooms.find(ourQuery).count()
});added count, total, and offset fields in response object
rodrigok
approved these changes
Mar 26, 2018
rodrigok
changed the title
Merged
Contributor
|
I just noticed that this API doesn't follow the way other APIs are working, with the prefix of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added endpoint to retrieve all the mentions of a channel. Requested in this issue.