[FIX] Fix spelling of "collaborative"#10134
Merged
engelgabriel merged 2 commits intoRocketChat:masterfrom Jun 7, 2018
Merged
Conversation
reece8765
reviewed
Mar 20, 2018
reece8765
left a comment
reece8765
left a comment
There was a problem hiding this comment.
Tbh I’d approve this, but I haven really used GitHub for that long and I don’t wanna mess this project up XD
jack17529
reviewed
Mar 25, 2018
| <div class="rc-user-info__row rc-user-info__row--separator"> | ||
| <div class="rc-switch-double"> | ||
| <div class="rc-switch-double__label {{equal true value 'disabled'}}"> | ||
| {{_ "Colaborative"}}{{equal default value '*'}} |
There was a problem hiding this comment.
@stuartpb and this was issue number ?
Contributor
Author
There was a problem hiding this comment.
Do I really need a separate issue for a one-character spelling fix?
Contributor
|
@RocketChat/ui I can't tell is this one translated? If so we probably need the i18n files updated? |
Contributor
|
@geekgonecrazy yep, apparently we don't have "Collaborative" key on our i18n files. @stuartpb can you add this key? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core