[NEW] Continuous sound notifications for new LiveChat rooms#10151
[NEW] Continuous sound notifications for new LiveChat rooms#10151sampaiodiego merged 7 commits intodevelopfrom
Conversation
sampaiodiego
left a comment
There was a problem hiding this comment.
the "new room sound" is playing for every new message (exactly what the setting says) but the issue is talking about playing the "new room sound" continuously only for new rooms and not new messages
|
@sampaiodiego, thanks for your feedback. |
Now the sound notification will be played only in new livechat rooms.
|
Fixed PR review. |
There was a problem hiding this comment.
@rocketchat/core does anyone know... If this isn't unset does it keep executing? Or does the meteor wrapper here work just like normal setTimeout?
532df3d to
d5e4e14
Compare
|
There is an issue in this PR that needs to be reviewed. |
|
New room sound notification was being paused when any room got focus. Now it's fixed. |
|
too* :) |
|
😘 |
@RocketChat/core
Closes #9847
This PR adds a new feature that allows to send continuous sound notifications when a new Livechat message arrives.
This means that the Livechat agent will hear sound notifications while there is a room with at least one unread message.