Skip to content

[NEW] Support for dynamic slack and rocket.chat channels#10205

Merged
rodrigok merged 20 commits intoRocketChat:developfrom
Hudell:dynamic-groups
Jun 19, 2018
Merged

[NEW] Support for dynamic slack and rocket.chat channels#10205
rodrigok merged 20 commits intoRocketChat:developfrom
Hudell:dynamic-groups

Conversation

@Hudell
Copy link
Contributor

@Hudell Hudell commented Mar 23, 2018 •
edited
Loading

@RocketChat/core

Closes an item on #8012 , merging PR #6282
Also closes #6509
Original description:

The goal of this pull request was to support Slack and Rocket channels coming and going. You had to enable/disable the slack bridge for it to pick up on changes.
Refactored the code into multiple files to allow for easier contributions in the future.
Fixed a 'not defined' error that was polluting the server logs
Improved logging/debugging messages some more

@Hudell Hudell added this to the 0.63.0 milestone Mar 23, 2018
@Hudell Hudell self-assigned this Mar 23, 2018
@Hudell Hudell mentioned this pull request Mar 26, 2018
Merged
@rodrigok rodrigok modified the milestones: 0.63.0, 0.64.0 Mar 27, 2018
@Hudell Hudell mentioned this pull request Mar 29, 2018
Merged
@Hudell Hudell mentioned this pull request Apr 3, 2018
Closed
@rodrigok rodrigok modified the milestones: 0.64.0, 0.66.0 May 22, 2018
@rodrigok
Copy link
Member

rodrigok commented May 22, 2018

@Hudell can you fix the conflict?

engelgabriel
engelgabriel previously requested changes Jun 11, 2018
View reviewed changes
packages/rocketchat-slackbridge/package.js Outdated
Copy link
Member

@engelgabriel engelgabriel Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding this here?

@Hudell Hudell mentioned this pull request Jun 11, 2018
Closed
@Hudell Hudell requested a review from graywolf336 June 13, 2018 18:59
@Hudell Hudell mentioned this pull request Jun 15, 2018
Closed
rodrigok
rodrigok reviewed Jun 19, 2018
View reviewed changes
packages/rocketchat-slackbridge/server/slackbridge.js Outdated
Copy link
Member

@rodrigok rodrigok Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this do something?

packages/rocketchat-slackbridge/server/slackbridge.js Outdated
Copy link
Member

@rodrigok rodrigok Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this do something?

packages/rocketchat-slackbridge/server/slackbridge.js Outdated
Copy link
Member

@rodrigok rodrigok Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this do something?

@rodrigok rodrigok merged commit d292a37 into RocketChat:develop Jun 19, 2018
@Hudell Hudell deleted the dynamic-groups branch June 19, 2018 21:34
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

@engelgabriel engelgabriel engelgabriel left review comments

@graywolf336 graywolf336 Awaiting requested review from graywolf336

Assignees

@Hudell Hudell

Labels

None yet

Projects

None yet

Milestone

0.66.0

Development

Successfully merging this pull request may close these issues.

Slackbridge one way if channel was created in Rocket first

4 participants

@Hudell @rodrigok @engelgabriel @pierre-lehnen-rc

Comments