[FIX] Missing Translation Key on Reactions#10270
Merged
Conversation
karlprieb
previously approved these changes
Mar 29, 2018
graywolf336
reviewed
Mar 29, 2018
Contributor
There was a problem hiding this comment.
Shouldn't this be "No Reactions"? 🤔
Contributor
There was a problem hiding this comment.
Because "no reacting" sounds like reacting is not allowed..
Contributor
There was a problem hiding this comment.
Agreed unless I'm not understanding the context. This should for sure be "No Reactions"
graywolf336
previously approved these changes
Mar 30, 2018
Contributor
graywolf336
left a comment
graywolf336
left a comment
There was a problem hiding this comment.
I have updated the translations and their strings to make more sense.
Contributor
|
Why not: Allow Reacting? Or Disallow Reacting? No reacting just doesn't sound right in this context |
geekgonecrazy
approved these changes
Mar 30, 2018
graywolf336
approved these changes
Mar 30, 2018
Merged
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Apr 6, 2018
* develop: (91 commits) [FIX] Audio Message UI fixes (RocketChat#10303) [NEW] Improve history generation (RocketChat#10319) Strip the colons when searching (RocketChat#10323) Bump snap version to include security fix (RocketChat#10313) Update Meteor to 1.6.1.1 (RocketChat#10314) [FIX] Unable to mention after newline in message (RocketChat#10078) [FIX] Wrong pagination information on /api/v1/channels.members (RocketChat#10224) [FIX] Inline code following a url leads to autolinking of code with url (RocketChat#10163) Fixed issue on incoming webhooks that caused the content raw to not be available (RocketChat#10258) [FIX] Missing Translation Key on Reactions (RocketChat#10270) Fix: inputs for rocketchat apps (RocketChat#10274) Fix: chat.react api not accepting previous emojis (RocketChat#10290) Fix: Scroll on content page (RocketChat#10300) [FIX] File had redirect delay when using external storage services and no option to proxy only avatars Add quotes in the endpoint deprecation warning Add deprecation warning to user.roles endpoint Improve pt-BR translations Fix caddy download link to pull from github Renaming channels.notifications Get/Post endpoints to subscriptions.getOne and rooms.saveNotifications Revert the removed endpoint, user.roles ... # Conflicts: # package-lock.json
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Apr 6, 2018
* goalify: (200 commits) Add S3 upload script Remove root-priviledged command switch gitlab ci config to use shell executor Try another build fix change language not reload temporary disable readonly [FIX] Audio Message UI fixes (RocketChat#10303) [NEW] Improve history generation (RocketChat#10319) Strip the colons when searching (RocketChat#10323) Bump snap version to include security fix (RocketChat#10313) Update Meteor to 1.6.1.1 (RocketChat#10314) [FIX] Unable to mention after newline in message (RocketChat#10078) [FIX] Wrong pagination information on /api/v1/channels.members (RocketChat#10224) [FIX] Inline code following a url leads to autolinking of code with url (RocketChat#10163) Fixed issue on incoming webhooks that caused the content raw to not be available (RocketChat#10258) [FIX] Missing Translation Key on Reactions (RocketChat#10270) Fix: inputs for rocketchat apps (RocketChat#10274) Fix: chat.react api not accepting previous emojis (RocketChat#10290) Fix: Scroll on content page (RocketChat#10300) change weather city to location ... # Conflicts: # .docker/Dockerfile # .sandstorm/sandstorm-pkgdef.capnp # .travis/snap.sh # HISTORY.md # package.json # packages/rocketchat-lib/rocketchat.info # packages/rocketchat-lib/server/functions/deleteUser.js # packages/rocketchat-theme/client/imports/components/main-content.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #10158
This PR fixes a bug with translation on reactions. There was a key missing on the i18n file.