[NEW] Switch channel with keyboard shortcuts

[cmrd-senya]

@RocketChat/core

Closes #4256

This adds support for switching channels using keyboard shortcuts. I'm expecting this not to be a final version and I expect the code to change according with the community feedback.

In the present version I supported two pairs of combinations: alt + up/alt + down and ctrl + tab/ctrl + shift + tab. The latter is conflicting with the browser hotkeys for switching tab, but I think it is useful for the users of the desktop version because it is consistent with how other desktop chat clients work. But if support ctrl + (shift) + tab we have to block them on the web version then. I don't know how is it possible to achieve.

Anyway, I think I need some feedback since it is my first PR for Rocket.Chat and it is the first time I work with Meteor, so I'm not too confident about the code.

[graywolf336]

Can you fix the linting issues? That way we can review this better?

[cmrd-senya]

Updated with lint issues fixed.

[iprok]

Anything else blocking merging this to the rocket chat release? It's highly requested feature for us.

[cmrd-senya]

Please change status to "review required", because requested changes were commited

[vynmera]

@graywolf336 ↑

[iprok]

@graywolf336 any problem with this request? Would like to see in the next release

I'm dismissing this review since the requested changes were made.

[tassoevan]

@ggazzo Can you check all that __helpers usage? I'm not sure if it safe to use them, I don't think it's a strong reason to block this PR though.

[ggazzo]

@cmrd-senya we dont use __helper, usually we create a common function to use cross templates.
ps: use RocketChat.roomTypes.openRouteLink(nextRoom.t, nextRoom); instead of

const name = RocketChat.roomTypes.getRouteLink(nextRoom.t, nextRoom);
FlowRouter.go(name);

any problem ask, @tassoevan will help you :)

[cmrd-senya]

@cmrd-senya we dont use __helper, usually we create a common function to use cross templates.

@ggazzo, where do you normally put the common functions?

[cmrd-senya]

@ggazzo, @tassoevan,
I have updated the PR. Now helper functions are extracted to a separate file and imported to templates and to the channel switching code.

Please review.

[tassoevan]

Added a commit encapsulating the event attachments into a function to be called on template creation, leaving the module scope just for declarations. Also, I'm going to merge #12564 first, avoiding a conflict when writing a documentation for this new shortcuts.

[cmrd-senya]

Added a commit encapsulating the event attachments into a function to be called on template creation, leaving the module scope just for declarations.

Tested, works for me.

Also, I'm going to merge #12564 first, avoiding a conflict when writing a documentation for this new shortcuts.

So I'll have to add documentation to this PR after #12564 is merged?

[tassoevan]

Don't worry, I am ready to change it. I'll just request your review when done.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tassoevan
❌ Senya

---

Senya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}