Skip to content

[FIX] Autocomplete list when inviting a user was partial hidden#10409

Merged
rodrigok merged 5 commits intodevelopfrom
fix-add-users-popup-list
Apr 16, 2018
Merged

[FIX] Autocomplete list when inviting a user was partial hidden#10409
rodrigok merged 5 commits intodevelopfrom
fix-add-users-popup-list

Conversation

@karlprieb
Copy link
Contributor

Closes #10393

Before:
image

After:
image

@karlprieb karlprieb added the area: ui Touches the code on client side label Apr 10, 2018
@karlprieb karlprieb added this to the 0.64.0 milestone Apr 10, 2018
@karlprieb karlprieb requested a review from gdelavald April 10, 2018 17:56
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10409 April 10, 2018 17:57 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10409 April 10, 2018 17:58 Inactive
@gdelavald
Copy link
Contributor

image
Seems to have a fixed width even when list is smaller

@karlprieb
Copy link
Contributor Author

@gdelavald that's another bug. It already exist on develop branch. You can try on open.rocket.chat

@karlprieb
Copy link
Contributor Author

Thank you @gdelavald for your review :)
I fixed the forced height on popup list, take a look:

2018-04-11 14 54 20

Copy link
Contributor

@gdelavald gdelavald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodrigok rodrigok changed the title [FIX] Add users popup list is broke [FIX] Autocomplete list when inviting a user was partial hidden Apr 16, 2018
@rodrigok rodrigok merged commit a982399 into develop Apr 16, 2018
@rodrigok rodrigok deleted the fix-add-users-popup-list branch April 16, 2018 14:46
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add users search is broken

4 participants

Comments