[FIX] Wrong column positions in the directory search for users#10454
Merged
rodrigok merged 2 commits intoRocketChat:developfrom Apr 19, 2018
Merged
[FIX] Wrong column positions in the directory search for users#10454rodrigok merged 2 commits intoRocketChat:developfrom
rodrigok merged 2 commits intoRocketChat:developfrom
Conversation
karlprieb
previously approved these changes
Apr 15, 2018
Contributor
|
Thanks 👍 |
Contributor
|
Why the space between the ampersand sign and the username? Looks so off to me. |
Contributor
Author
|
@graywolf336 Actually there was a space before "@" and "name". Should I remove this one? |
Contributor
|
I believe so, to be consistent with the rest of the places we have the ampersand signs and usernames together. |
lunaticmonk
force-pushed
the
directory-users
branch
from
9443ddd to
6f2207f
Compare
Contributor
Author
|
@graywolf336 Done 👍 |
karlprieb
approved these changes
Apr 17, 2018
rodrigok
changed the title
MarcosSpessatto
pushed a commit
that referenced
this pull request
Apr 19, 2018
…-api-chat-postmessage-validations * commit 'a9fb4da5c847a456990a5d60369f0f52ff4a8bd8': (137 commits) Remove "secret" from REST endpoint /settings.oauth response [FIX] Directory sort and column sizes were wrong (#10403) [FIX] Add oauth services missing fields, and indicate whether the oauth service is customized (#10299) Show error message when email verification fails (#10446) Correct the column positions in the directory search for users (#10454) Fixed custom fields misalignment in registration form (#10463) [FIX] Unique identifier file not really being unique (#10341) [OTHER] More Listeners for Apps & Utilize Promises inside Apps (#10335) [FIX] Empty panel after changing a user's username (#10404) [FIX] Russian translation of "False" (#10418) [FIX] Links being embedded inside of blockquotes (#10496) [FIX] The 'channel.messages' REST API Endpoint error (#10485) [OTHER] Develop sync (#10487) [FIX] Button on user info contextual bar scrolling with the content (#10358) [FIX] "Idle Time Limit" using milliseconds instead of seconds (#9824) [NEW] Body of the payload on an incoming webhook is included on the request object (#10259) [FIX] Missing i18n translation key for "Unread" (#10387) [FIX] Owner unable to delete channel or group from APIs (#9729) [NEW] REST endpoint to recover forgotten password (#10371) Add REST endpoint chat.reportMessage, to report a message (#10354) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10398
Before:
After:
@karlprieb Please review.