[FIX] Messages was grouping wrong some times when server is slow#10472
[FIX] Messages was grouping wrong some times when server is slow#10472
Conversation
gdelavald
changed the title
gdelavald
changed the title
gdelavald
force-pushed
the
fix-grouping-on-slow-server
branch
from
5ef2b0f to
c1ee40a
Compare
|
You da man! That's been haunting us for a while now 😁 |
rodrigok
changed the title
|
|
||
| const loadMissedMessages = function(rid) { | ||
| const lastMessage = ChatMessage.findOne({rid}, {sort: {ts: -1}, limit: 1}); | ||
| const lastMessage = ChatMessage.findOne({rid, temp: { $exists: false } }, {sort: {ts: -1}, limit: 1}); |
| const currentNode = domRange.lastNode(); | ||
| const currentDataset = currentNode.dataset; | ||
| const previousNode = currentNode.previousElementSibling; | ||
| const getPreviousSentMessage = (currentNode) => { |
There was a problem hiding this comment.
My biggest concern here is performance. If we are creating a new function for every message, then I can imagine the memory level just went up a little bit more...
There was a problem hiding this comment.
Makes sense, can we have some monitoring on unstable and develop when this hits? @geekgonecrazy
There was a problem hiding this comment.
@graywolf336 do you think simply moving the function to outer scope would help?
There was a problem hiding this comment.
I'm not entirely sure about that, as I don't know if it would be created everytime the template is initialized. That would be something to test.
There was a problem hiding this comment.
I don't know how garbage collector works for these lambda functions used/created on closed contexts.. if that is a real problem or not..
what I know is moving it to file's root scope will define it once and will not run every time the template is initialized.
7 participants
Closes #9926
Tested locally with @geekgonecrazy's script for load testing and this seems to fix most of the issues.
Reproducing while offline (Messages on the right are grouped with the wrong user)
After fix:
Even though the timestamp is not respected, the messages are grouped correctly.