[NEW] Option to mute group mentions (@all and @here)#10502
Merged
Conversation
Contributor
|
Is this a user preference? I am just thinking that there can be some channels, like say announcements, which admins of a server don't want people to turn off this type of notification...any ideas? |
Contributor
Author
|
It's a user preference, per channel. Allowing admins to disable this preference for certain channels would also be a nice feature to have, but I don't see it as a requirement. |
Contributor
|
Maybe we should merge this PR and create another issue to work on this "improvement", what you guys think? |
Contributor
|
Do we currently have an option for admins to disable notifications preferences for users? |
Contributor
|
@Hudell what do you think about calling it group mentions instead of generic? I think its a bit more meaningful. I think this would be a great thing to have. |
ggazzo
previously approved these changes
Apr 20, 2018
ggazzo
force-pushed
the
mute-generic-mentions
branch
from
02b73c7 to
a394d5e
Compare
…ket.Chat.git; branch 'mute-generic-mentions' of github.com:RocketChat/Rocket.Chat into mute-generic-mentions
ggazzo
force-pushed
the
mute-generic-mentions
branch
from
a394d5e to
31f4486
Compare
ggazzo
approved these changes
Apr 21, 2018
ggazzo
changed the title
engelgabriel
added a commit
that referenced
this pull request
Apr 21, 2018
trongthanh
added a commit
to goalifyplus/Goalify.Chat
that referenced
this pull request
Apr 27, 2018
* develop: (79 commits) fixed problems with margin negative (RocketChat#10558) Add some information regarding Zapier and Bots to the integrations page (RocketChat#10574) Added target="_blank" to homepage and support link. (RocketChat#10575) [FIX] Stop Firefox announcement overflowing viewport (RocketChat#10503) [FIX] Wordpress oAuth authentication wasn't behaving correctly (RocketChat#10550) Fix inconsistent response of settings.oauth endpoint (RocketChat#10553) Regression: Remove added mentions on quote/reply (RocketChat#10571) Fix the attachments and fields incorrectly failing on validation (RocketChat#10573) Deps update (RocketChat#10549) Map consumerKey to clientId (fix Twitter) (RocketChat#10560) Regression: Webhooks breaking duo to a too restrict test (RocketChat#10555) Fix issues with the rooms and apps (RocketChat#10559) Fix regression with announcement bar being displayed without content (RocketChat#10554) LingoHub based on develop (RocketChat#10545) Regression: Revert announcement structure (RocketChat#10544) Regression: Upload was not working (RocketChat#10543) Remove duplicated key from en.i18n.json Included missing lib (RocketChat#10532) dependencies update [NEW] Option to mute group mentions (@ALL and @here) (RocketChat#10502) ... # Conflicts: # packages/rocketchat-i18n/i18n/en.i18n.json # packages/rocketchat-i18n/i18n/vi-VN.i18n.json # packages/rocketchat-ui-flextab/client/tabs/membersList.html # packages/rocketchat-ui-message/client/popup/messagePopupConfig.js # packages/rocketchat-ui-sidenav/client/sidebarHeader.js
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1654
This PR adds a new preference on the channel notification settings to mute
@alland@heremention notifications.