[NEW] Option to ignore users on channels by ggazzo · Pull Request #10517 · RocketChat/Rocket.Chat

ggazzo · 2018-04-19T21:44:22Z

Closes #9785

as @rodrigok said on #9785

Specification:

The list will be per room
Will be saved in user's subscription as an array of users to mute
~~Will be a field in room's setting using the component we already have to select users when creating a new channel~~
There will be a button in user's detail view and in message's context menu to mute/unmute the user (methods to be developed)
Will show an icon (to be defined) in members list to mark muted users
Will affect the rendering of the messages
Will hide the user's messages when listed in muted array but will keep the username adding a button to expand/show the messages
Should not send notifications and emails of messages from muted users
~Should update the array of muted usernames when user change his username (RocketChat._setUsername)
The minimized message will be designed soon ??

@gdelavald thanks <3

…nto ignore0user

… into ignore0user

graywolf336

As stated in this comment, #9785 (comment), the rest api wrapper is needed as well.

ggazzo · 2018-04-20T01:17:13Z

I'm waiting for the API too (:

ggazzo · 2018-04-20T01:18:18Z

just a joke <3

graywolf336

Are there plans for the UX/UI piece to be improved?

graywolf336 · 2018-04-20T02:50:33Z

packages/rocketchat-api/server/v1/chat.js

typeof ignore === typeof '' seriously? I mean no offense, but are you intentionally trying to make unreadable code?? typeof ignore === 'string' is way more readable than what is currently there..

I really like this way =/ sorry for make the code more unreadable

graywolf336 · 2018-04-20T02:50:36Z

packages/rocketchat-api/server/v1/chat.js

+		if (!rid || !rid.trim()) {
+			throw new Meteor.Error('error-room-id-param-not-provided', 'The required "rid" param is missing.');
+		}
+		if (!userId || !userId.trim()) {


Add a new line before this. (I'm being nitpicky, but yeah).

graywolf336 · 2018-04-20T02:50:59Z

packages/rocketchat-api/server/v1/chat.js

Missing space near the end and the first ending }..

graywolf336 · 2018-04-20T02:58:13Z

packages/rocketchat-lib/server/lib/sendNotificationsOnMessage.js

Should this contain a safety type check of Array.isArray(subscription.ignored)? It would replace the first check since null or undefined isn't an array. Just trying to think in case the data somehow gets corrupted (highly unlikely but yeah)..

graywolf336 · 2018-04-20T03:02:40Z

packages/rocketchat-ui-flextab/client/tabs/membersList.js

Can you fix this spacing?

As a note, why exactly is this in this pull request?

because I was working on member list and I saw that problem... maybe I should made an special commit for that

graywolf336 · 2018-04-20T03:05:24Z

packages/rocketchat-ui/client/lib/RoomHistoryManager.js

For readability, can the call to the function be moved to the next line?

graywolf336 · 2018-04-20T03:05:30Z

packages/rocketchat-ui/client/lib/RoomHistoryManager.js

For readability, can the call to the function be moved to the next line?

graywolf336 · 2018-04-20T03:06:11Z

packages/rocketchat-ui/client/lib/RoomManager.js

Fix this spacing :)

graywolf336 · 2018-04-20T03:07:18Z

server/methods/ignoreUser.js

+Meteor.methods({
+	ignoreUser({rid, userId: ignoredUser, ignore = true}) {
+		check(ignoredUser, String);
+		check(rid, String);


You're type checking everything but the ignore. Is there a good reason behind this or can it be type checked as well?

just because the name suggest ignore and the param is a boolean so we can define a default... if you dont pass any information I will assume you really want ignore, if you passfalse you want remove the ignore , I dont like the idea of have 2 methods to do the same thing...

Right, but what if I pass a string to this method? That's what I'm saying, add a type check to ensure the value being passed is a boolean as you assume it always will be.

hmmm yep you are right :p

karlprieb · 2018-04-20T03:29:57Z

@graywolf336 yep... we will change this design probably on the RC. Our design team is working on that.

@ggazzo

waiting for @ggazzo type checker update

Addressed

ggazzo and others added 11 commits April 18, 2018 22:03

added ignored flag on messages

db30bd7

Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…

b7c3588

…nto ignore0user

Revert change to map that breaks subscriptions

7fcbfe7

Adds toggling to show ignored message

65b1b73

Add new icon, ignore message and css for sequential messages

7385581

ignore user on message action

2080f32

Merge remote-tracking branch 'origin/ignore0user' into ignore0user

45d7c46

Add i18n for ignored message

05f4336

Merge branch 'ignore0user' of https://github.com/RocketChat/Rocket.Chat…

5046b14

… into ignore0user

Adds translations and fixes access to undefined subscriptions

4758873

removed file

b8ab420

engelgabriel temporarily deployed to rocket-chat-pr-10517 April 19, 2018 21:44 Inactive

Merge remote-tracking branch 'origin/ignore0user' into ignore0user

143b0e7

ggazzo requested review from gdelavald, karlprieb and rodrigok April 19, 2018 22:28

ignored title i18n and fix popover on member list

09fbfce

ggazzo temporarily deployed to rocket-chat-pr-10517 April 19, 2018 22:30 Inactive

Merge branch 'develop' into ignore0user

26f31e5

ggazzo temporarily deployed to rocket-chat-pr-10517 April 19, 2018 22:30 Inactive

ggazzo added 2 commits April 19, 2018 19:31

i18n

fd18b2b

Merge remote-tracking branch 'origin/ignore0user' into ignore0user

31c70cf

ggazzo temporarily deployed to rocket-chat-pr-10517 April 19, 2018 22:31 Inactive

graywolf336 suggested changes Apr 19, 2018

View reviewed changes

do not allow ignore user on DM

bfcf0ff

ggazzo had a problem deploying to rocket-chat-pr-10517 April 19, 2018 23:06 Failure

ignore user rest method

e592bf5

ggazzo temporarily deployed to rocket-chat-pr-10517 April 20, 2018 01:17 Inactive

gdelavald temporarily deployed to rocket-chat-pr-10517 April 20, 2018 02:42 Inactive

RocketChat deleted a comment Apr 20, 2018

graywolf336 previously requested changes Apr 20, 2018

View reviewed changes

ggazzo added 2 commits April 20, 2018 01:04

fix review

b5ad5ad

fix review

c84cc28

ggazzo temporarily deployed to rocket-chat-pr-10517 April 20, 2018 04:06 Inactive

fix css identation

14927de

engelgabriel temporarily deployed to rocket-chat-pr-10517 April 20, 2018 07:11 Inactive

fix more css identation

2ab6f5e

engelgabriel temporarily deployed to rocket-chat-pr-10517 April 20, 2018 07:12 Inactive

karlprieb previously approved these changes Apr 20, 2018

View reviewed changes

karlprieb added the area: ui Touches the code on client side label Apr 20, 2018

karlprieb added this to the 0.64.0 milestone Apr 20, 2018

ggazzo added 2 commits April 20, 2018 09:59

check if ignore param is a boolean

b564b20

Merge remote-tracking branch 'origin/ignore0user' into ignore0user

782fc6b

ggazzo temporarily deployed to rocket-chat-pr-10517 April 20, 2018 21:22 Inactive

ggazzo temporarily deployed to rocket-chat-pr-10517 April 20, 2018 21:49 Inactive

remove file metor.id

2867de7

ggazzo force-pushed the ignore0user branch from 80b4823 to 2867de7 Compare April 20, 2018 21:53

ggazzo deployed to rocket-chat-pr-10517 April 20, 2018 21:53 View deployment

rodrigok approved these changes Apr 20, 2018

View reviewed changes

karlprieb approved these changes Apr 20, 2018

View reviewed changes

rodrigok changed the title ~~[NEW] Ignore user on channels~~ [NEW] Option to ignore users on channels Apr 20, 2018

rodrigok merged commit 93b1641 into develop Apr 20, 2018

rodrigok deleted the ignore0user branch April 20, 2018 22:34

rodrigok mentioned this pull request Apr 28, 2018

Release 0.64.0 #10613

Merged

MarcosSpessatto mentioned this pull request Mar 21, 2019

Document chat.ignoreUser API endpoint RocketChat/docs-old#1149

Merged

Conversation

ggazzo commented Apr 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Specification:

Uh oh!

graywolf336 left a comment

Choose a reason for hiding this comment

Uh oh!

ggazzo commented Apr 20, 2018

Uh oh!

ggazzo commented Apr 20, 2018

Uh oh!

graywolf336 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ggazzo Apr 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karlprieb commented Apr 20, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

ggazzo commented Apr 19, 2018 •

edited

Loading

ggazzo Apr 20, 2018 •

edited

Loading