[FIX] Image lazy load was breaking attachments

[ggazzo]

List to check

• Avatars

• Attachments

Closes #10895

[sampaiodiego]

change el to element

[JSzaszvari]

@ggazzo Not sure if this is related, but seeing this as well when running tests as well as my staging environment.

When searching for a user, a good majority of the time none of the avatars show up like this:

Happy to log a separate bug report if you'd like, But not sure if it's related to this issue.

Not seeing anything in the console or logs, except for the initial click on the search button witch throws the following whenever it's clicked

index.js:40 Uncaught TypeError: el.getBoundingClientRect is not a function
    at index.js:40```

[ggazzo]

thanks @JSzaszvari I think its working now :x

[ggazzo]

<3

[ghost]

When can we expect this to be merged?

[JSzaszvari]

Amazing @ggazzo - Working great now

[vynmera]

Please add this as hotfix, it is currently causing a lot of issues on my team (we have to resort to the insecure imgur now, or tell people to download the images)
Thank you!

[glebtv]

This is a user script to work around this issue:

setInterval(function() {
	document.querySelectorAll(".attachment-image img").forEach(function(v) { if (v.src != v.dataset.src) {v.src = v.dataset.src; } })
}, 1000)

[ggazzo]

@glebtv you could remove the lazy-img class...

setInterval(function() {
	document.querySelectorAll(".attachment-image .lazy-img").forEach(function(el) { 
    	el.src = el.dataset.src;
		el.removeAttribute('data-src');
		el.className = el.className.replace('lazy-img', '');
	})
}, 1000)

but I think until the end of day it will be released