Skip to content

[FIX] Confirm password on set new password user profile#11095

Merged
ggazzo merged 4 commits intodevelopfrom
confirm-new-password-on-edit-account
Jun 12, 2018
Merged

[FIX] Confirm password on set new password user profile#11095
ggazzo merged 4 commits intodevelopfrom
confirm-new-password-on-edit-account

Conversation

@tassoevan
Copy link
Contributor

Related to #10730

@tassoevan tassoevan requested a review from ggazzo June 11, 2018 19:40
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11095 June 11, 2018 19:40 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11095 June 11, 2018 19:41 Inactive
Copy link
Member

@engelgabriel engelgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please changes the PR #9969 to make sure we are using the same translation keys and remove the setting they have created for the placeholder using a migration

@ggazzo ggazzo dismissed engelgabriel’s stale review June 12, 2018 15:59

;) both are right

@tassoevan tassoevan added the area: ui Touches the code on client side label Jun 12, 2018
@tassoevan tassoevan self-assigned this Jun 12, 2018
@tassoevan tassoevan added this to the 0.66.0 milestone Jun 12, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11095 June 12, 2018 19:53 Inactive
@ggazzo ggazzo changed the title [FIX] Input for confirmation of new password on edit account profile [FIX] Confirm password on set new password user profile Jun 12, 2018
@ggazzo ggazzo merged commit a18fe25 into develop Jun 12, 2018
@ggazzo ggazzo deleted the confirm-new-password-on-edit-account branch June 12, 2018 21:03
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments