Skip to content

[FIX] Popover position#11113

Merged
ggazzo merged 5 commits intodevelopfrom
popover-appearance-position-fix
Jun 13, 2018
Merged

[FIX] Popover position#11113
ggazzo merged 5 commits intodevelopfrom
popover-appearance-position-fix

Conversation

@tassoevan
Copy link
Contributor

Closes #10668

@tassoevan tassoevan added the area: ui Touches the code on client side label Jun 12, 2018
@tassoevan tassoevan added this to the 0.66.0 milestone Jun 12, 2018
@tassoevan tassoevan self-assigned this Jun 12, 2018
@tassoevan tassoevan requested a review from ggazzo June 12, 2018 22:26
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11113 June 12, 2018 22:27 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11113 June 13, 2018 03:15 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11113 June 13, 2018 04:08 Inactive
@tassoevan tassoevan changed the title [WIP] [FIX] Popover appearance position [FIX] Popover appearance position Jun 13, 2018
@tassoevan tassoevan removed their assignment Jun 13, 2018
@vynmera
Copy link
Contributor

vynmera commented Jun 13, 2018

Very nice!! After fiddling around on the current deployment, here's the things I found that still need work:

Emoji picker overlaps the message box (move it up):
2018-06-13_19-44-08

Channel 3dots looks a bit unnatural (move it a bit to the left?)
2018-06-13_19-44-42

All else looks correct! 🎉

@ggazzo ggazzo changed the title [FIX] Popover appearance position [FIX] Popover position Jun 13, 2018
@ggazzo ggazzo merged commit 5434b0e into develop Jun 13, 2018
@ggazzo ggazzo deleted the popover-appearance-position-fix branch June 13, 2018 17:57
@vynmera
Copy link
Contributor

vynmera commented Jun 13, 2018

@ggazzo uhhh, am I the only one seeing these issues (or do they not need to be fixed)?

@vynmera
Copy link
Contributor

vynmera commented Jun 13, 2018

Nevermind, it turns out that's how they're meant to be. Guess I lived with the broken version too long :-)
I suppose I might make a PR to fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments