Regression: Add missing LiveChat permission to allow removing closed rooms#11423
Merged
sampaiodiego merged 2 commits intodevelopfrom Jul 21, 2018
Merged
Regression: Add missing LiveChat permission to allow removing closed rooms#11423sampaiodiego merged 2 commits intodevelopfrom
sampaiodiego merged 2 commits intodevelopfrom
Conversation
Member
|
should we call this a regression or maybe a fix? you're not creating a new permission, just fixing the fact it is not being created previously. |
renatobecker-zz
changed the title
renatobecker-zz
changed the title
renatobecker-zz
changed the title
sampaiodiego
changed the title
sampaiodiego
approved these changes
Jul 21, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a new LiveChat permission to allow removing closed LiveChat rooms.
In PR #10301 we created a migration to add this new permission, but for new installations this permission was missing.