[FIX] Fixing rooms find by type and name#11451
Merged
ggazzo merged 4 commits intoRocketChat:developfrom Feb 7, 2019
Merged
Conversation
…1451-hmagarotto-fix_get_room_by_type_and_name
ggazzo
approved these changes
Feb 7, 2019
Montel
pushed a commit
to Montel/Rocket.Chat
that referenced
this pull request
Feb 13, 2019
* Fixing getRoomByTypeAndName * Update room.js * Update Rooms.js
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to standardize the 'room' variable type inside 'getRoomByTypeAndName'.
Before, room is attributed with a Room object or an array of Room. When it's a Room object and an attempt to access the index 0 occurs, the room is set to undefined and the following exception is raised on line 100:
Exception while invoking method 'getRoomByTypeAndName' TypeError: Cannot read property '_id' of undefined