Skip to content

[FIX] Fixed text for "bulk-register-user"#11558

Merged
ggazzo merged 9 commits intoRocketChat:developfrom
CyberTechCafe-LLC:develop
Feb 5, 2019
Merged

[FIX] Fixed text for "bulk-register-user"#11558
ggazzo merged 9 commits intoRocketChat:developfrom
CyberTechCafe-LLC:develop

Conversation

@the4ndy
Copy link
Contributor

@the4ndy the4ndy commented Jul 24, 2018

The same text was used for bulk-register-c (channels) and bulk-register-user. Adjusted the text for bulk-register-user and its associated description line in the English translation JSON file.

The same text was used for bulk-register-c (channels) and bulk-register-user. Adjusted the text for bulk-register-user and its associated description line in the English translation JSON file.
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2018

CLA assistant check
All committers have signed the CLA.

@the4ndy
Copy link
Contributor Author

the4ndy commented Jul 25, 2018

Is there something else I need to do for this? The one check is still pending and this is my first time contributing to this project and I want to make sure I didnt miss anything. The fix is a simple change to a mistyped string so it shouldnt effect any building and should be an easy review. let me know how i can help. Thanks.

vynmera
vynmera previously approved these changes Jul 25, 2018
Copy link
Contributor

@vynmera vynmera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Don't worry about the fifth check staying on Pending - this is normal. 4 passed checks = your build passed!

@the4ndy
Copy link
Contributor Author

the4ndy commented Dec 19, 2018

I am a little confused. It seems as though the change I corrected with this pull request was fixed else where? Is that accurate? does that happen often? I was hoping to have "contributed" but i guess someone found it also and included it with another pull request (im guessing one that fixed more than just some text). Just wondering. Thanks

@ggazzo ggazzo added the area: ui Touches the code on client side label Feb 5, 2019
@ggazzo ggazzo requested a review from tassoevan February 5, 2019 03:19
@ggazzo ggazzo added this to the 0.75.0 milestone Feb 5, 2019
@ggazzo ggazzo merged commit e01418d into RocketChat:develop Feb 5, 2019
Montel pushed a commit to Montel/Rocket.Chat that referenced this pull request Feb 13, 2019
The same text was used for bulk-register-c (channels) and bulk-register-user. Adjusted the text for bulk-register-user and its associated description line in the English translation JSON file.
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments