[FIX] Files list missing from popover menu when owner of room#11565
Merged
geekgonecrazy merged 5 commits intodevelopfrom Sep 27, 2018
Merged
[FIX] Files list missing from popover menu when owner of room#11565geekgonecrazy merged 5 commits intodevelopfrom
geekgonecrazy merged 5 commits intodevelopfrom
Conversation
ggazzo
previously requested changes
Aug 16, 2018
| }, | ||
|
|
||
| embeddedVersion() { | ||
| embeddVersion() { |
Contributor
Author
There was a problem hiding this comment.
Eww, a random deletion...
geekgonecrazy
approved these changes
Sep 27, 2018
Contributor
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
This would be great to get in
geekgonecrazy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11105
Replacing
thiswithTemplate.instance()in helpers fixed the problem.