Skip to content

[NEW] Apps: API provider#11938

Merged
sampaiodiego merged 15 commits intodevelopfrom
apps/webhhoks
Sep 26, 2018
Merged

[NEW] Apps: API provider#11938
sampaiodiego merged 15 commits intodevelopfrom
apps/webhhoks

Conversation

@rodrigok
Copy link
Member

@rodrigok rodrigok commented Sep 3, 2018

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11938 September 3, 2018 18:41 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-11938 September 7, 2018 13:53 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-11938 September 7, 2018 15:10 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-11938 September 7, 2018 22:17 Inactive
@rodrigok rodrigok changed the title [WIP] [NEW] Apps: Webhook provider [NEW] Apps: Webhook provider Sep 7, 2018
@geekgonecrazy
Copy link
Contributor

Wow!! This is going to be absolutely fantastic. Loving that you can set private or public.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11938 September 20, 2018 19:03 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-11938 September 20, 2018 19:09 Inactive
geekgonecrazy
geekgonecrazy previously approved these changes Sep 20, 2018
Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

@rodrigok
Copy link
Member Author

@geekgonecrazy I'm planing to change the naming to API instead of Webhooks

@rodrigok rodrigok changed the title [NEW] Apps: Webhook provider [WIP] [NEW] Apps: Webhook provider Sep 20, 2018
@geekgonecrazy
Copy link
Contributor

@rodrigok do you need help doing this? I'd love to be able to start using this.

@rodrigok
Copy link
Member Author

@geekgonecrazy I need, I'm busy finishing the E2E encryption for the release :(

@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-11938 September 20, 2018 23:49 Inactive
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@rodrigok
Copy link
Member Author

We need someway to pass the hash and appid that was used to mound the endpoint to the endpoint scope be able to generate the final url to pass to external services.

I need that to configure the atlassian integrations for example.

@rodrigok rodrigok temporarily deployed to rocket-chat-pr-11938 September 22, 2018 03:01 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-11938 September 26, 2018 01:37 Inactive
@rodrigok rodrigok temporarily deployed to rocket-chat-pr-11938 September 26, 2018 01:38 Inactive
@rodrigok rodrigok changed the title [WIP] [NEW] Apps: Webhook provider [NEW] Apps: Api provider Sep 26, 2018
@rodrigok rodrigok added this to the 0.70.0 milestone Sep 26, 2018
Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and excited for it :)

@rodrigok
Copy link
Member Author

rodrigok commented Sep 26, 2018 via email

@sampaiodiego sampaiodiego changed the title [NEW] Apps: Api provider [NEW] Apps: API provider Sep 26, 2018
@sampaiodiego sampaiodiego merged commit 2af8b1e into develop Sep 26, 2018
@sampaiodiego sampaiodiego deleted the apps/webhhoks branch September 26, 2018 18:34
This was referenced Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments