Merged
Conversation
6 tasks
Contributor
|
Wow!! This is going to be absolutely fantastic. Loving that you can set private or public. |
geekgonecrazy
previously approved these changes
Sep 20, 2018
Contributor
geekgonecrazy
left a comment
There was a problem hiding this comment.
This looks good to me. 👍
Member
Author
|
@geekgonecrazy I'm planing to change the naming to API instead of Webhooks |
Contributor
|
@rodrigok do you need help doing this? I'd love to be able to start using this. |
Member
Author
|
@geekgonecrazy I need, I'm busy finishing the E2E encryption for the release :( |
Member
Author
|
We need someway to pass the hash and appid that was used to mound the endpoint to the endpoint scope be able to generate the final url to pass to external services. I need that to configure the atlassian integrations for example. |
geekgonecrazy
approved these changes
Sep 26, 2018
graywolf336
reviewed
Sep 26, 2018
graywolf336
approved these changes
Sep 26, 2018
Contributor
graywolf336
left a comment
There was a problem hiding this comment.
Looking good and excited for it :)
Member
Author
|
When throwing an error from an endpoint or returning a promise rejection.
… On Sep 25, 2018, at 11:23 PM, Bradley Hilton ***@***.***> wrote:
@graywolf336 commented on this pull request.
In packages/rocketchat-apps/server/bridges/api.js:
> + method: req.method.toLowerCase(),
+ headers: req.headers,
+ query: req.query || {},
+ params: req.params || {},
+ content: req.body,
+ privateHash: req._privateHash,
+ };
+
+ this.orch.getManager().getApiManager().executeApi(appId, endpoint.path, request)
+ .then(({ status, headers = {}, content }) => {
+ res.set(headers);
+ res.status(status);
+ res.send(content);
+ })
+ .catch((reason) => {
+ // Should we handle this as an error?
Good question. When would this happen?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on RocketChat/Rocket.Chat.Apps-engine#61