[NEW] Customizable default directory view#11965
Merged
sampaiodiego merged 8 commits intoRocketChat:developfrom Sep 20, 2018
Merged
[NEW] Customizable default directory view#11965sampaiodiego merged 8 commits intoRocketChat:developfrom
sampaiodiego merged 8 commits intoRocketChat:developfrom
Conversation
Update for codacy comment: Unexpected whitespace at end of line (no-eol-whitespace)
keithhenning
previously approved these changes
Sep 7, 2018
Contributor
Author
|
This would close #12003 |
|
@ohmonster can you provide some screen shot? |
Contributor
Author
|
@mnlbox Here is the new setting in administration. One thing that became more noticeable when channels was no longer default was the default sort on the channels list. It was different depending on whether the list loaded by default or if you clicked Users then Channels. This PR makes the initial sort the same for both (by User count, descending) |
sampaiodiego
approved these changes
Sep 20, 2018
Member
|
Thank you for the contribution 😄 I had to do a small fix regarding our new lint rules, it's now fine to merge 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Allow the user to set whether the Directory page initially displays the Channels list or the Users list.
(Related refinements: update style sheet so scroll bar appears with long lists when viewed in the Windows client. When changing tabs, set the sort values to be consistent with the initial directory display.)
Closes #12003