Skip to content

[NEW] Customizable default directory view#11965

Merged
sampaiodiego merged 8 commits intoRocketChat:developfrom
ohmonster:develop
Sep 20, 2018
Merged

[NEW] Customizable default directory view#11965
sampaiodiego merged 8 commits intoRocketChat:developfrom
ohmonster:develop

Conversation

@ohmonster
Copy link
Contributor

@ohmonster ohmonster commented Sep 5, 2018

Allow the user to set whether the Directory page initially displays the Channels list or the Users list.

(Related refinements: update style sheet so scroll bar appears with long lists when viewed in the Windows client. When changing tabs, set the sort values to be consistent with the initial directory display.)

Closes #12003

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2018

CLA assistant check
All committers have signed the CLA.

Update for codacy comment: Unexpected whitespace at end of line (no-eol-whitespace)
@RocketChat RocketChat deleted a comment Sep 5, 2018
keithhenning
keithhenning previously approved these changes Sep 7, 2018
@ohmonster
Copy link
Contributor Author

This would close #12003

@engelgabriel engelgabriel added this to the 0.70.0 milestone Sep 13, 2018
@mnlbox
Copy link

mnlbox commented Sep 13, 2018

@ohmonster can you provide some screen shot?

@ohmonster
Copy link
Contributor Author

ohmonster commented Sep 13, 2018

@mnlbox Here is the new setting in administration.
image

One thing that became more noticeable when channels was no longer default was the default sort on the channels list. It was different depending on whether the list loaded by default or if you clicked Users then Channels. This PR makes the initial sort the same for both (by User count, descending)
image

@sampaiodiego
Copy link
Member

Thank you for the contribution 😄

I had to do a small fix regarding our new lint rules, it's now fine to merge 🚀

@sampaiodiego sampaiodiego changed the title [NEW] customizable default directory view [NEW] Customizable default directory view Sep 20, 2018
@sampaiodiego sampaiodiego merged commit 4c558f6 into RocketChat:develop Sep 20, 2018
This was referenced Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] It would be more convenient to first open the list of users when going to the directory

6 participants

Comments