Skip to content

[NEW] reply with a file#12095

Merged
ggazzo merged 9 commits intodevelopfrom
fix/attachment-on-reply
Mar 1, 2019
Merged

[NEW] reply with a file#12095
ggazzo merged 9 commits intodevelopfrom
fix/attachment-on-reply

Conversation

@rssilva
Copy link
Contributor

@rssilva rssilva commented Sep 18, 2018

Closes #11799

screen shot 2018-09-18 at 1 02 38 pm

screen shot 2018-09-18 at 1 02 45 pm

@rssilva rssilva self-assigned this Sep 18, 2018
@rssilva rssilva added the area: ui Touches the code on client side label Sep 18, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12095 September 18, 2018 16:11 Inactive
@rssilva rssilva force-pushed the fix/attachment-on-reply branch from ba47536 to df15aa3 Compare September 18, 2018 16:15
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12095 September 18, 2018 16:15 Inactive
@rssilva rssilva added this to the 0.70.0 milestone Sep 19, 2018
@rssilva rssilva force-pushed the fix/attachment-on-reply branch from df15aa3 to 8e7b73f Compare September 24, 2018 19:58
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12095 September 24, 2018 19:59 Inactive
@rssilva rssilva force-pushed the fix/attachment-on-reply branch from 8e7b73f to 38fa40a Compare September 25, 2018 12:37
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12095 September 25, 2018 12:37 Inactive
@rssilva rssilva force-pushed the fix/attachment-on-reply branch from 38fa40a to 483409b Compare September 26, 2018 12:05
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12095 September 26, 2018 12:06 Inactive
@rssilva rssilva mentioned this pull request Sep 26, 2018
Merged
@rssilva rssilva force-pushed the fix/attachment-on-reply branch from 483409b to 9c9f12c Compare September 26, 2018 17:49
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12095 September 26, 2018 17:49 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12095 September 27, 2018 05:21 Inactive
geekgonecrazy
geekgonecrazy previously approved these changes Sep 27, 2018
View reviewed changes
@ggazzo ggazzo modified the milestones: 0.70.0, 0.71.0 Sep 27, 2018
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-12095 October 2, 2018 17:00 Inactive
@rssilva @ggazzo
[NEW] Reply/quote multiple messages (#12171)
7dc2fca 
* Allowing quote multiple messages. Need to fix: removing messages from array when cancelling/after send message

* Using messages array from the html data attribute instead creating a reactive variable

* Avoiding to have the same message to be quoted multiple times

* Removing debug code

* fix style reply messages
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-12095 October 2, 2018 17:05 Inactive
@ggazzo ggazzo changed the title [FIX] Fixing file attachment to be possible to reply with a file [NEW] Fixing file attachment to be possible to reply with a file Oct 2, 2018
@ggazzo ggazzo changed the title [NEW] Fixing file attachment to be possible to reply with a file [NEW] reply with a file Oct 2, 2018
@rodrigok rodrigok modified the milestones: 0.71.0, 0.72.0 Nov 1, 2018
@tassoevan tassoevan modified the milestones: 0.72.0, 0.73.0 Nov 29, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12095 December 18, 2018 16:17 Inactive
@tassoevan tassoevan requested review from ggazzo and rodrigok December 18, 2018 16:20
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-12095 December 21, 2018 16:29 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-12095 December 21, 2018 16:31 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-12095 March 1, 2019 19:19 Inactive
@ggazzo ggazzo force-pushed the fix/attachment-on-reply branch from 727cb9d to e170c38 Compare March 1, 2019 19:20
@rodrigok
Copy link
Member

rodrigok commented Mar 1, 2019

Should we add milestone 1.0 for this one?

@ggazzo
Copy link
Member

ggazzo commented Mar 1, 2019

I will merge it now

@ggazzo ggazzo modified the milestones: 0.73.0, 1.0.0 Mar 1, 2019
@ggazzo ggazzo merged commit 9672b4f into develop Mar 1, 2019
@ggazzo ggazzo deleted the fix/attachment-on-reply branch March 1, 2019 20:19
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy left review comments

@ggazzo ggazzo Awaiting requested review from ggazzo

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees

@rssilva rssilva

Labels

area: ui Touches the code on client side

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Reply with attachments does not work

6 participants

@rssilva @rodrigok @ggazzo @geekgonecrazy @engelgabriel @tassoevan

Comments