[FIX] Livechat agent joining on pick from guest pool#12097
Conversation
The new client will have tests from the start. We need to start adding tests on Rocket.Chat side as well. |
Awesome! When is it going to hit the road? |
|
I was hoping to have the new client by this release 😞 hopefully we can have it by the next one 🤞 |
|
Hi @mrsimpson, I think your fix conflict with #11011. In this pull request he changed |
|
@IITNTII thanks for notifying! Obviously, this was overlapping. @renatobecker and I just learned this the hard way before I recalled your message. |
…hat#12097)" This reverts commit 933378a.
What this fixes
As a guest's conversation is picked from the livechat queue, the agent is getting assigned to the room.
However, this was not properly subscribed to on the widget.
This lead to multiple issues:
What's been done
The streamer subscription had a filter which did not match the actual property of the room.
It's a one-liner, but has quite nasty side-effects - and was tedious to fix. Any efforts on providing integration tests for livechat on the horizon?