[FIX] Allow user with "bulk-register-user" permission to send invitations#12112
Merged
geekgonecrazy merged 3 commits intoRocketChat:developfrom Sep 25, 2018
Merged
Conversation
geekgonecrazy
approved these changes
Sep 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
When allowing a user to send invitation mails (permission
bulk-register-users), a user who already had the permission to view administration and manage users could still not send the invitation emails. The panel was simply blank.How it's been implemented
The authorization
bulk-register-userswas not checked earlier, but whether the user has theadminrole.Since
bulk-register-usersis assigned toadminby default, the permission can safely be used without data migration.