Skip to content

Comments

Better organize package.json#12115

Merged
sampaiodiego merged 2 commits intodevelopfrom
organize-packagejson
Sep 20, 2018
Merged

Better organize package.json#12115
sampaiodiego merged 2 commits intodevelopfrom
organize-packagejson

Conversation

@sampaiodiego
Copy link
Member

I've done a few things on this PR:

  • Merge eslint and stylelint into lint npm script. This is better IMO because where ever we use lint script (like husky pre-push hook) it will validate both javascript and css.
  • Changed to use Meteor's npm instead of installed on host. This will make sure the correct npm version is used to everything
  • Removed npm i from start script. This doesn't make sense IMO and was causing changes to package-lock.json everytime start was called.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-12115 September 20, 2018 17:17 Inactive
@sampaiodiego sampaiodiego merged commit b4bc4c2 into develop Sep 20, 2018
@sampaiodiego sampaiodiego deleted the organize-packagejson branch September 20, 2018 22:41
This was referenced Sep 28, 2018
reist pushed a commit to seekingalpha/Rocket.Chat that referenced this pull request Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants