Skip to content

Comments

[NEW] Hide inactive rooms#12117

Closed
mrsimpson wants to merge 4 commits intoRocketChat:developfrom
assistify:core/feature/hide-inactive-rooms
Closed

[NEW] Hide inactive rooms#12117
mrsimpson wants to merge 4 commits intoRocketChat:developfrom
assistify:core/feature/hide-inactive-rooms

Conversation

@mrsimpson
Copy link
Contributor

@mrsimpson mrsimpson commented Sep 20, 2018

What this adds

As time does by, users are being subscribed to many rooms. The left-hand side navigation gets messy. This PR adds an action for the user to hide inactive rooms.

2018-09-20 23 22 41
Note the read conversations vanishing ;)
Remark: the icon is eye-off - it's just not shown on my local dev-env

How this is implemented

  • It adds an option to the sort-list. There is no better place for cross-room-actions, imho - the user preferences would be too far off.
  • With a modal, a user can define how old the minimum age is for rooms to be hidden.
  • Favorites and unread rooms are exempted
  • The implementation is similar to the normal hide-leave-actions with respect to package and model assignment.

What could be improved

  • Default value for the modal. This needs a modification of the modal (modal.html, line 36ff ({{#if input}})). I didn't do this since it's a reuse component and wanted to get your feedback first.
  • Create a regular ob and have the age defined by each user in its preferences (might be a second PR)

@mrsimpson mrsimpson self-assigned this Sep 20, 2018
@mrsimpson mrsimpson requested a review from a team September 20, 2018 21:36
@kaiiiiiiiii
Copy link
Contributor

kaiiiiiiiii commented Sep 20, 2018

IMO the user preferences are the perfect place for such settings. It’s something you may change once in a while, but nothing that needs to be super accessible :)

Awesome PR btw., I really missed that feature after we migrated from slack (:

@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@RocketChat RocketChat deleted a comment Sep 20, 2018
@graywolf336
Copy link
Contributor

I like the way this one is set up, as the user preferences feels hidden.

@graywolf336 graywolf336 added this to the 0.72.0 milestone Oct 26, 2018
@theorenck theorenck modified the milestones: 0.72.0, Short-term Dec 12, 2018
@engelgabriel engelgabriel modified the milestones: Short-term, 0.75.0 Feb 8, 2019
@engelgabriel engelgabriel requested a review from ggazzo March 21, 2019 23:36
@engelgabriel engelgabriel added the area: ui Touches the code on client side label Mar 21, 2019
@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 6, 2019
@rodrigok rodrigok modified the milestones: 1.1.0, 1.2.0 May 15, 2019
@engelgabriel engelgabriel modified the milestones: 1.2.0, 1.3.0 Jul 10, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@mrsimpson
Copy link
Contributor Author

@ggazzo Nobody cared about this change so far - and I think it should be implemented properly. Can you or someone from @RocketChat/core please give some feedback on whether this feature is desired?

@ggazzo ggazzo modified the milestones: 2.0.0, 2.1.0 Aug 27, 2019
@engelgabriel engelgabriel modified the milestones: 2.1.0, 2.2.0 Oct 13, 2019
@ggazzo ggazzo modified the milestones: 2.2.0, 2.3.0 Oct 18, 2019
@mrsimpson
Copy link
Contributor Author

Closing this MR since I'll not be adapting it for a merge. However, I consider the feature elementary, but with another implementation

@mrsimpson mrsimpson closed this Jan 28, 2020
@mrsimpson mrsimpson deleted the core/feature/hide-inactive-rooms branch December 7, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants