Closed
Conversation
1e62454 to
5cee4db
Compare
Contributor
|
IMO the user preferences are the perfect place for such settings. It’s something you may change once in a while, but nothing that needs to be super accessible :) Awesome PR btw., I really missed that feature after we migrated from slack (: |
Contributor
|
I like the way this one is set up, as the user preferences feels hidden. |
18 tasks
Contributor
Author
|
@ggazzo Nobody cared about this change so far - and I think it should be implemented properly. Can you or someone from @RocketChat/core please give some feedback on whether this feature is desired? |
Contributor
Author
|
Closing this MR since I'll not be adapting it for a merge. However, I consider the feature elementary, but with another implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
As time does by, users are being subscribed to many rooms. The left-hand side navigation gets messy. This PR adds an action for the user to hide inactive rooms.
Note the read conversations vanishing ;)
Remark: the icon is
eye-off- it's just not shown on my local dev-envHow this is implemented
What could be improved
modal.html, line 36ff ({{#if input}})). I didn't do this since it's a reuse component and wanted to get your feedback first.